[TAP5-1305] Service decorations can fail if using the conventional naming

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.1.0.4
• Fix Version/s: 5.4
• Component/s: tapestry-ioc
• Labels: month-of-tapestry
• Assignee: Thiago Henrique De Paula Figueiredo
• Reporter: Dan Adams
• Created: 13/Oct/10 20:51
• Updated: 27/Oct/17 13:45
• Resolved: 06/Jun/14 14:52

Description

If you have a service FooBar and 2 modules that each have:

public static FooBar decorateFooBar(FooBar delegate, ...)

you will get a logging message like this:

[WARN] com.example.services.BazModule.FooBar Could not add object with duplicate id 'FooBar'. The duplicate object has been ignored.

which results in one of the contributions (you don't know which one) being dropped. This is because T5 uses an ordered contribution internally when collecting the contributions and bases the id of the contribution based on the method name (drops "decorate").

It should either fail with an exception and a good error or support this behaviour. The problematic line is RegistryImpl.findDecoratorsForService (line 634).

The work-around is to use @Match("FooBar") on the method and name it something different such as "decoratingWithMyThingy".

Issue Links

• is related to: TAP5-2012 Make multiple same name service decoration methods error message better