Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-128

Render phase short circuiting fails to abort the event when mixins are present on the component, resulting in an IllegalStateException when trying to store a subsequent result value

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0.16
    • Component/s: None
    • Labels:
      None

      Description

      According to the docs on render phase short-circuiting for methods of the same phase:
      http://tapestry.apache.org/tapestry5/tapestry-core/guide/rendering.html

      "If a method returns a true or false value, this will short circuit processing.
      Other methods within the phase that would ordinarily be invoked will not be invoked."

      This is currently unimplemented. (Only other "inner" phases are short-circuited & not invoked.)

      Changes would primarily affect:
      org.apache.tapestry.internal.structure.ComponentCallback
      org.apache.tapestry.internal.structure.ComponentPageElementImpl

      In ComponentPageElementImpl.invoke(...), the loop:
      while (i.hasNext())
      callback.run(i.next());

      needs to implement the short circuiting, for example:
      while (i.hasNext())
      if (callback.run(i.next()))
      break;

      This change would cascade up to ComponentCallback and all its usage in ComponentPageElementImpl.

      Cheers,
      Nick.

        Attachments

          Activity

            People

            • Assignee:
              hlship Howard M. Lewis Ship
              Reporter:
              sicklittlemonkey Nick Westgate
            • Votes:
              2 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: