Tapestry 5
  1. Tapestry 5
  2. TAP5-1232

Restore injection of service id (as a String) into service decorator methods for proper backwards compatibility

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.2.0
    • Fix Version/s: 5.2.1
    • Component/s: None
    • Labels:
      None

      Description

      In this discussion we decided to turn off the injection of service ids as Strings.
      http://markmail.org/thread/bgue2rsmaxjt3xhs

      Unfortunately we forgot about the decorators. Tapestry's documentation contains examples in which a service id in injected when building a decorator.

      http://tapestry.apache.org/tapestry5.1/tapestry-ioc/decorator.html

      Even though dacorator API is deprecated, there are still apps using this feature. They will be broken after upgarde to 5.2

        Activity

        Hide
        Hudson added a comment -

        Integrated in tapestry-5.2-freestyle #171 (See http://hudson.zones.apache.org/hudson/job/tapestry-5.2-freestyle/171/)
        TAP5-1232: Removed auto-injection of service ids as String is backward incompatible with decorators

        Show
        Hudson added a comment - Integrated in tapestry-5.2-freestyle #171 (See http://hudson.zones.apache.org/hudson/job/tapestry-5.2-freestyle/171/ ) TAP5-1232 : Removed auto-injection of service ids as String is backward incompatible with decorators
        Hide
        Igor Drobiazko added a comment -

        Injection of service ids is provided for decorate and advise methods again.

        Show
        Igor Drobiazko added a comment - Injection of service ids is provided for decorate and advise methods again.
        Hide
        Igor Drobiazko added a comment -

        Hm, I'm not sure what is the best solution. We should discuss it in the dev mailing list again. Let's see what the others think.

        Show
        Igor Drobiazko added a comment - Hm, I'm not sure what is the best solution. We should discuss it in the dev mailing list again. Let's see what the others think.
        Hide
        Massimo Lusetti added a comment -

        Good catch! ... Did you plan to reintroduce the feature?

        Show
        Massimo Lusetti added a comment - Good catch! ... Did you plan to reintroduce the feature?

          People

          • Assignee:
            Igor Drobiazko
            Reporter:
            Igor Drobiazko
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development