Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-1203

Use of @Contribute annotation does not work properly with marker annotations

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.2.0
    • Fix Version/s: 5.2.0
    • Component/s: tapestry-ioc
    • Labels:
      None

      Description

      @Contribute is a great idea, but there are two problems (as discussed on the mailing list)

      1) Marker annotations on the contribute method should be simple annotation, not wrapped inside @Marker, i.e.:

      @Contribute(NameListHolder.class)
      @BlueMarker
      public void contributeBlueNames(...)

      2) The comparison of marker annotations on the contribution method to the marker annotations for the service is slightly off. It was done with equals(), but it should be that the service contains all maker annotations from the contribution method.

        Attachments

          Activity

            People

            • Assignee:
              hlship Howard M. Lewis Ship
              Reporter:
              hlship Howard M. Lewis Ship
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: