Uploaded image for project: 'Tapestry 5'
  1. Tapestry 5
  2. TAP5-1201

PageResponseRenderer.render() should call RequestGlobabls.storeActivePageName(String pageName)

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 5.2.0
    • 5.2.1
    • tapestry-core
    • None

    Description

      Applications may want render an error page as a response to handling an exception thrown from a page. This can be achieved by calling PageResponseRenderer.render() and worked in T5.1.05 but in T5.2 throws ComponentSource.getActivePage() throws "org.apache.tapestry5.ioc.internal.util.TapestryException: The identity of the active page for this request has not yet been established" if the newly added RequestGlobabls.storeActivePageName(String pageName) hasn't been called before. When asked on the mailing list (http://www.listware.net/201007/tapestry-users/10342-using-pageresponserendererrender-in-t52.html) for adding the call to PageResponseRenderer.render(), Howard's response was:
      "I suppose it could; just a case of unexpected use of the APIs. As currently coded, we assume that the active page is identified by the component event or page render dispatcher."

      Attachments

        1. TAP5-1201.patch
          2 kB
          Kalle Korhonen

        Activity

          People

            hlship Howard Lewis Ship
            kaosko Kalle Korhonen
            Votes:
            5 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: