Tapestry 5
  1. Tapestry 5
  2. TAP5-1060

In IE8, forms that should submit using Ajax are triggering full page requests due to a client-side JavaScript error

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 5.2.0
    • Fix Version/s: 5.2.0
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      The handleSubmit function in Tapestry.FormEventManager takes a domevent argument, which it expects is extended and has the stop() function. This works in Firefox since the event is already extended, but breaks in IE.

      It looks like this was introduced in revision 919693 of tapestry.js on 3/6/2010 when around line 1250 "Event.stop(domevent);" was changed to "domevent.stop();".

      The prototype recommendation is to call "Event.extend(domevent);" at the top of any callback bound using bindAsEventListener.

        Activity

        Brian Heston created issue -
        Hide
        Howard M. Lewis Ship added a comment -

        Interesting that Prototype doesn't extend the event before invoking the bound event listener function; is this considered a Prototype bug?

        Show
        Howard M. Lewis Ship added a comment - Interesting that Prototype doesn't extend the event before invoking the bound event listener function; is this considered a Prototype bug?
        Hide
        Brian Heston added a comment -

        I thought that was strange too, which is why I wrote the bug up for Prototype first: https://prototype.lighthouseapp.com/projects/8886/tickets/1012-event-parameter-not-extended-in-bindaseventlistener-callback. I could have sworn it used to work as we both seem to expect though.

        Show
        Brian Heston added a comment - I thought that was strange too, which is why I wrote the bug up for Prototype first: https://prototype.lighthouseapp.com/projects/8886/tickets/1012-event-parameter-not-extended-in-bindaseventlistener-callback . I could have sworn it used to work as we both seem to expect though.
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Summary FormEventManager Not Stopping Submit for Ajax Form in IE8 In IE8, forms that should submit using Ajax are triggering full page requests due to a client-side JavaScript error
        Priority Major [ 3 ] Critical [ 2 ]
        Howard M. Lewis Ship committed 924636 (1 file)
        Reviews: none

        TAP5-1060: In IE8, forms that should submit using Ajax are triggering full page requests due to a client-side JavaScript error

        Howard M. Lewis Ship made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Fix Version/s 5.2.0 [ 12314122 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Brian Heston
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development