[TAMAYA-326] ServiceContextManager picks second available service provider even if the ordinal is lower

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.3-incubating
• Fix Version/s: 0.4-incubating
• Component/s: Core
• Assignee: Philipp Ottlinger
• Reporter: William Lieurance
• Created: 30/Jan/18 06:37
• Updated: 05/Feb/18 20:51
• Resolved: 05/Feb/18 20:51

Description

While adding some test coverage on the api, I found that org.apache.tamaya.spi.ServiceContextManager has a bug as it searches for the default service provider in loadDefaultServiceProvider.  Namely, the "highestOrdinal" is not set after the first service provider is found, so any following service provider with an ordinal higher than 0 will be used, even if that ordinal is lower than the first one's.

I modified the test ServiceContext to demonstrate the bug, as well as fixed the logic on my branch in github.  Note that if you run the tests against the ServiceContextManager as-is, they will fail.

https://github.com/peculater/incubator-tamaya/commit/320d018566b5f32afecb79d33109e3c4606ba782 is the commit

https://github.com/peculater/incubator-tamaya/tree/TAMAYA-326 is the branch

 

Issue Links

• links to: GitHub Pull Request #10