Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-962

Column reference used in LIMIT clause incurs NPE.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      select * from LINEITEM limit L_ORDERKEY;
      

      Of course, any column reference is not allowed in LIMIT clause. But, the above query will cause NPE. This is an query validator bug.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/164

        TAJO-962: Column reference used in LIMIT clause incurs NPE.

        It fixed the bug and adds the unit test system for PreLogicalPlanVerifier.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-962

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/164.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #164


        commit d1557a6032ef86fd75a82119e1c0728197f31baf
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-09-27T00:00:04Z

        TAJO-962: Column reference used in LIMIT clause incurs NPE.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/164 TAJO-962 : Column reference used in LIMIT clause incurs NPE. It fixed the bug and adds the unit test system for PreLogicalPlanVerifier. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-962 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/164.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #164 commit d1557a6032ef86fd75a82119e1c0728197f31baf Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-09-27T00:00:04Z TAJO-962 : Column reference used in LIMIT clause incurs NPE.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/164#issuecomment-57419591

        +1

        Thank you for your contribution.
        It looks good to me and 'mvn clean install' finished successfully.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/164#issuecomment-57419591 +1 Thank you for your contribution. It looks good to me and 'mvn clean install' finished successfully.
        Hide
        hyunsik Hyunsik Choi added a comment -

        I've just committed the latest patch to master branch. Thank you for the review.

        Show
        hyunsik Hyunsik Choi added a comment - I've just committed the latest patch to master branch. Thank you for the review.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/164

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/164
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #380 (See https://builds.apache.org/job/Tajo-master-build/380/)
        TAJO-962: Column reference used in LIMIT clause incurs NPE. (hyunsik: rev bccac701d5c3467ec7d7b39a1f1dd10b73cadf76)

        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #380 (See https://builds.apache.org/job/Tajo-master-build/380/ ) TAJO-962 : Column reference used in LIMIT clause incurs NPE. (hyunsik: rev bccac701d5c3467ec7d7b39a1f1dd10b73cadf76) tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-CODEGEN-build #22 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/22/)
        TAJO-962: Column reference used in LIMIT clause incurs NPE. (hyunsik: rev bccac701d5c3467ec7d7b39a1f1dd10b73cadf76)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-CODEGEN-build #22 (See https://builds.apache.org/job/Tajo-master-CODEGEN-build/22/ ) TAJO-962 : Column reference used in LIMIT clause incurs NPE. (hyunsik: rev bccac701d5c3467ec7d7b39a1f1dd10b73cadf76) CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-block_iteration-branch-build #12 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/12/)
        TAJO-962: Column reference used in LIMIT clause incurs NPE. (hyunsik: rev bccac701d5c3467ec7d7b39a1f1dd10b73cadf76)

        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java
        • tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-block_iteration-branch-build #12 (See https://builds.apache.org/job/Tajo-block_iteration-branch-build/12/ ) TAJO-962 : Column reference used in LIMIT clause incurs NPE. (hyunsik: rev bccac701d5c3467ec7d7b39a1f1dd10b73cadf76) CHANGES tajo-core/src/test/java/org/apache/tajo/engine/planner/TestPreLogicalPlanVerifier.java tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java tajo-core/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development