Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-961

TajoCli should exit when at least one query faces error while executing a SQL script.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: SQL Shell
    • Labels:
      None

      Description

      Tsql can take a SQl script as follows:

      bin/tsql -f etl.sql
      

      etl.sql file can include multiple statements including meta comments, DDL, and DML statements. In current implementation, Tsql is hanging when it faces at least error while executing such a SQL script. The current Tsql behavior is not good for script users.

      Tsql should exit when it faces at least error.

      ``aa ``

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/82

        TAJO-961: TajoCli should exit when at least one query faces error while ...

        ...executing a SQL script.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-961

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/82.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #82


        commit c4099a02a96efe6821f82f465ca9acfb8b453955
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-07-20T08:46:59Z

        TAJO-961: TajoCli should exit when at least one query faces error while executing a SQL script.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/82 TAJO-961 : TajoCli should exit when at least one query faces error while ... ...executing a SQL script. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-961 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/82.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #82 commit c4099a02a96efe6821f82f465ca9acfb8b453955 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-07-20T08:46:59Z TAJO-961 : TajoCli should exit when at least one query faces error while executing a SQL script.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/82#issuecomment-49540815

        Issue num is wrong. I'll make new pr.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/82#issuecomment-49540815 Issue num is wrong. I'll make new pr.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik closed the pull request at:

        https://github.com/apache/tajo/pull/82

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik closed the pull request at: https://github.com/apache/tajo/pull/82
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/84

        TAJO-961: TajoCli should exit when at least one query faces error while ...

        ...executing a SQL script.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-961

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/84.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #84


        commit 8dc00a456b7c0edd1a5a4336b1e274abde740cd6
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-07-20T11:21:20Z

        TAJO-961: TajoCli should exit when at least one query faces error while executing a SQL script.


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/84 TAJO-961 : TajoCli should exit when at least one query faces error while ... ...executing a SQL script. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-961 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/84.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #84 commit 8dc00a456b7c0edd1a5a4336b1e274abde740cd6 Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-07-20T11:21:20Z TAJO-961 : TajoCli should exit when at least one query faces error while executing a SQL script.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user blrunner commented on the pull request:

        https://github.com/apache/tajo/pull/84#issuecomment-49544651

        +1

        Thanks @hyunsik,
        I testes your patch on local testing cluster. It ran as expected.

        Push it.

        Show
        githubbot ASF GitHub Bot added a comment - Github user blrunner commented on the pull request: https://github.com/apache/tajo/pull/84#issuecomment-49544651 +1 Thanks @hyunsik, I testes your patch on local testing cluster. It ran as expected. Push it.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/84

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/84
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #307 (See https://builds.apache.org/job/Tajo-master-build/307/)
        TAJO-961: TajoCli should exit when at least one query faces error while executing a SQL script. (hyunsik) (hyunsik: rev 6dac6a5b8764720a40740f7bb27ef48be1c0f7d5)

        • tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #307 (See https://builds.apache.org/job/Tajo-master-build/307/ ) TAJO-961 : TajoCli should exit when at least one query faces error while executing a SQL script. (hyunsik) (hyunsik: rev 6dac6a5b8764720a40740f7bb27ef48be1c0f7d5) tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java CHANGES

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development