Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-953

RawFile should release a DirectBuffer immediately

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.9.0
    • Component/s: Data Shuffle
    • Labels:
      None

      Description

      RawFile allocated memory is a native DirectBuffer. This memory will be freed when the finalize method is called by gc.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user jinossy opened a pull request:

        https://github.com/apache/tajo/pull/79

        TAJO-953: RawFile should release a DirectBuffer immediately

        RawFile allocated memory is a native DirectBuffer. This memory will be freed when the finalize method is called by gc

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/jinossy/tajo TAJO-953

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/79.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #79


        commit d27abb93941e336ca5ed7ea65ebac889406e09da
        Author: jinossy <jinossy@gmail.com>
        Date: 2014-07-17T07:21:27Z

        TAJO-953: RawFile should release a DirectBuffer immediately


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user jinossy opened a pull request: https://github.com/apache/tajo/pull/79 TAJO-953 : RawFile should release a DirectBuffer immediately RawFile allocated memory is a native DirectBuffer. This memory will be freed when the finalize method is called by gc You can merge this pull request into a Git repository by running: $ git pull https://github.com/jinossy/tajo TAJO-953 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/79.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #79 commit d27abb93941e336ca5ed7ea65ebac889406e09da Author: jinossy <jinossy@gmail.com> Date: 2014-07-17T07:21:27Z TAJO-953 : RawFile should release a DirectBuffer immediately
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/79#issuecomment-49283865

        +1 Ship it.

        Even though it does not include the unit tests, the change is straightforward.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/79#issuecomment-49283865 +1 Ship it. Even though it does not include the unit tests, the change is straightforward.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/79

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/79
        Hide
        jhkim Jinho Kim added a comment -

        committed. Thank you for the review

        Show
        jhkim Jinho Kim added a comment - committed. Thank you for the review
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #302 (See https://builds.apache.org/job/Tajo-master-build/302/)
        TAJO-953: RawFile should release a DirectBuffer immediately. (jinho) (jinossy: rev 3df7fda36bfcb3869878f72d90830315b0584f2e)

        • CHANGES
        • tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #302 (See https://builds.apache.org/job/Tajo-master-build/302/ ) TAJO-953 : RawFile should release a DirectBuffer immediately. (jinho) (jinossy: rev 3df7fda36bfcb3869878f72d90830315b0584f2e) CHANGES tajo-storage/src/main/java/org/apache/tajo/storage/StorageUtil.java tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development