Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: SQL Shell
    • Labels:

      Description

      I found that tsql prints wrong version with tajo-0.9.0-SNAPSHOT as follows:

      default> \?
      
      General
        \copyright  show Apache License 2.0
        \version    show Tajo version
        \?          show help
        \q          quit tsql
      
      
      Informational
        \l           list databases
        \c           show current database
        \c [DBNAME]  connect to new database
        \d           list tables
        \d [TBNAME]  describe table
        \df          list functions
        \df NAME     describe function
      
      
      Tool
        \!           execute a linux shell command
        \dfs         execute a dfs command
        \admin       execute tajo admin command
      
      
      Variables
        \set [[NAME] [VALUE]  set session variable or list session variables
        \unset NAME           unset session variable
      
      
      Documentations
        tsql guide        http://tajo.apache.org/docs/0.8.0/cli.html
        Query language    http://tajo.apache.org/docs/0.8.0/sql_language.html
        Functions         http://tajo.apache.org/docs/0.8.0/functions.html
        Backup & restore  http://tajo.apache.org/docs/0.8.0/backup_and_restore.html
        Configuration     http://tajo.apache.org/docs/0.8.0/configuration.html
      
      default> \version
      0.8.0-SNAPSHOT
      
      1. TAJO-912.Mai.140708.2.patch.txt
        3 kB
        Mai Hai Thanh
      2. TAJO-912.Hyunsik.140711.1.patch
        4 kB
        Hyunsik Choi

        Activity

        Hide
        mhthanh Mai Hai Thanh added a comment -

        Update constant TAJO_VERSION from "0.8.0-SNAPSHOT" to "0.9.0-SNAPSHOT".

        If the documents for this new version are accessible, links to documentation will be changed from ".../docs/0.8.0/..." to ".../docs/0.9.0/..." . Otherwise, they will be changed to ".../docs/current/...".

        Show
        mhthanh Mai Hai Thanh added a comment - Update constant TAJO_VERSION from "0.8.0-SNAPSHOT" to "0.9.0-SNAPSHOT". If the documents for this new version are accessible, links to documentation will be changed from ".../docs/0.8.0/..." to ".../docs/0.9.0/..." . Otherwise, they will be changed to ".../docs/current/...".
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12654272/TAJO-912.Mai.140707.0.patch.txt
        against master revision 10caff0.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-client tajo-common.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/457//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/457//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/457//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/457//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12654272/TAJO-912.Mai.140707.0.patch.txt against master revision 10caff0. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 11 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/457//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/457//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/457//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/457//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Hi Mai Hai Thanh,

        Your patch looks good to me. Originally, your direction is right. BTW, we already have VersionInfo in tajo-common module utility class to allow Tajo to get version, source revision, and build information. BTW, we haven't used it so far. In addition, if you use HttpURLConnection.openConnection in HelpCommand, HelpCommand will not work in private network environments in which Hadoop cluster usually are running.

        Could you change your patch to use VersionInfo class?

        Thanks,
        Hyunsik

        Show
        hyunsik Hyunsik Choi added a comment - Hi Mai Hai Thanh, Your patch looks good to me. Originally, your direction is right. BTW, we already have VersionInfo in tajo-common module utility class to allow Tajo to get version, source revision, and build information. BTW, we haven't used it so far. In addition, if you use HttpURLConnection.openConnection in HelpCommand, HelpCommand will not work in private network environments in which Hadoop cluster usually are running. Could you change your patch to use VersionInfo class? Thanks, Hyunsik
        Hide
        mhthanh Mai Hai Thanh added a comment -

        Hi Hyunsik Choi,

        I changed my patch to use VersionInfo as you suggested. With regard to the use of HttpURLConnection class, I understand that it will not work if Tajo is used in a private network. However, to check the existence of a document stored on the internet, I cannot find any better way. In case the internet access is not available for HelpCommand, we will get an Exception or a non-(HTTP_OK) response code. Thus, the links to documents will point to the "current" version, which seems to be a safe choice.

        Hi Tajo QA,

        Among the "11 new Findbugs warnings", only 1 is from my code. So, I tried to resolve that one, but not the remaining 10 unrelated warnings. Besides, how can I "justify why no new tests are needed for this patch" when I create a patch so that Findbugs will not complain about this "test included" issue ? (I am also a newbie to Findbugs)

        Thanks,
        Thanh

        Show
        mhthanh Mai Hai Thanh added a comment - Hi Hyunsik Choi, I changed my patch to use VersionInfo as you suggested. With regard to the use of HttpURLConnection class, I understand that it will not work if Tajo is used in a private network. However, to check the existence of a document stored on the internet, I cannot find any better way. In case the internet access is not available for HelpCommand, we will get an Exception or a non-(HTTP_OK) response code. Thus, the links to documents will point to the "current" version, which seems to be a safe choice. Hi Tajo QA, Among the "11 new Findbugs warnings", only 1 is from my code. So, I tried to resolve that one, but not the remaining 10 unrelated warnings. Besides, how can I "justify why no new tests are needed for this patch" when I create a patch so that Findbugs will not complain about this "test included" issue ? (I am also a newbie to Findbugs) Thanks, Thanh
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12654431/TAJO-912.Mai.140708.0.patch.txt
        against master revision 10caff0.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-client tajo-common.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/458//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/458//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/458//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/458//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12654431/TAJO-912.Mai.140708.0.patch.txt against master revision 10caff0. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/458//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/458//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/458//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/458//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Hi Mai,

        As you mentioned, your proposal seems the nice way to choose available documentation version.

        But, I still have a concern. HttpURLConnection in many firewall environments may be hang until connection timeout. In contrast, showing the latest and available document version is relatively less important to us. What do you think about that?

        Tajo QA is a bot for automatically integration test. So far, we have used TajoQA's findbug report and resolved the findbug errors. Now, please ignore the findbug error. Recently we've started using github pull request as another patch submission way. It omits findbug test. So, we need to change some workflow. After than, we need to resolve them in another jira issues.

        Show
        hyunsik Hyunsik Choi added a comment - Hi Mai, As you mentioned, your proposal seems the nice way to choose available documentation version. But, I still have a concern. HttpURLConnection in many firewall environments may be hang until connection timeout. In contrast, showing the latest and available document version is relatively less important to us. What do you think about that? Tajo QA is a bot for automatically integration test. So far, we have used TajoQA's findbug report and resolved the findbug errors. Now, please ignore the findbug error. Recently we've started using github pull request as another patch submission way. It omits findbug test. So, we need to change some workflow. After than, we need to resolve them in another jira issues.
        Hide
        mhthanh Mai Hai Thanh added a comment -

        Hi Hyunsik,

        To solve your concern that HttpURLConnection may be hang, I think that we can set the timeout values (for example, 1 second) with functions setConnectTimeout() and setReadTimeout(). I uploaded a new patch that incorporated this solution.

        In my opinion, unless we do not show the links to the documents, we should show "alive" links because it gives the user the feeling that we still care about Tajo (i.e., this produce has not been abandoned yet). Hence, I think that showing alive links to either a specific version or the current version is important. However, although showing an "available" version is important, showing "the latest" version is less important. When an old version of Tajo is installed, we should show the documents of that old version if they are available.

        If you change the workflow to use pull requests for submitting patches, please update Tajo's web page "How to Contribute to Tajo" with new instructions.

        Thanh

        Show
        mhthanh Mai Hai Thanh added a comment - Hi Hyunsik, To solve your concern that HttpURLConnection may be hang, I think that we can set the timeout values (for example, 1 second) with functions setConnectTimeout() and setReadTimeout(). I uploaded a new patch that incorporated this solution. In my opinion, unless we do not show the links to the documents, we should show "alive" links because it gives the user the feeling that we still care about Tajo (i.e., this produce has not been abandoned yet). Hence, I think that showing alive links to either a specific version or the current version is important. However, although showing an "available" version is important, showing "the latest" version is less important. When an old version of Tajo is installed, we should show the documents of that old version if they are available. If you change the workflow to use pull requests for submitting patches, please update Tajo's web page "How to Contribute to Tajo" with new instructions. Thanh
        Hide
        hyunsik Hyunsik Choi added a comment -

        Ok, I accept your proposal. Your claim is reasonable.

        In addition, could you add one member variable to contain the target document version that HelpCommand instance will use? It will avoid repeated delay or hanging which may occur in some network environments.

        After we discuss the workflow change, I'll update the wiki page or website. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - Ok, I accept your proposal. Your claim is reasonable. In addition, could you add one member variable to contain the target document version that HelpCommand instance will use? It will avoid repeated delay or hanging which may occur in some network environments. After we discuss the workflow change, I'll update the wiki page or website. Thanks!
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12654482/TAJO-912.Mai.140708.1.patch.txt
        against master revision b9a3972.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-client tajo-common.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/459//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/459//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/459//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/459//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12654482/TAJO-912.Mai.140708.1.patch.txt against master revision b9a3972. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/459//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/459//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/459//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/459//console This message is automatically generated.
        Hide
        mhthanh Mai Hai Thanh added a comment -

        OK, I uploaded a new patch with a new class member for target document version to avoid repeated delay.

        Show
        mhthanh Mai Hai Thanh added a comment - OK, I uploaded a new patch with a new class member for target document version to avoid repeated delay.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12654489/TAJO-912.Mai.140708.2.patch.txt
        against master revision b9a3972.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-client tajo-common.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/461//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/461//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/461//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/461//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12654489/TAJO-912.Mai.140708.2.patch.txt against master revision b9a3972. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/461//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/461//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/461//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/461//console This message is automatically generated.
        Hide
        mhthanh Mai Hai Thanh added a comment -

        Hi, should we close this issue ?

        Show
        mhthanh Mai Hai Thanh added a comment - Hi, should we close this issue ?
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1
        Your patch looks good to me. In addition, I changed some trivial things as follows:

        If there is no objection, I'll commit it shortly.

        Show
        hyunsik Hyunsik Choi added a comment - +1 Your patch looks good to me. In addition, I changed some trivial things as follows: Remove unused imports. Replace org.apache.hadoop.util.VersionInfo by org.apache.tajo.util.VersionInfo. Reindent the changes with 2 space. It would be useful to you ( https://cwiki.apache.org/confluence/display/TAJO/Code+Style ) If there is no objection, I'll commit it shortly.
        Hide
        hyunsik Hyunsik Choi added a comment -

        After a patch is committed, an issue is usually closed.

        Show
        hyunsik Hyunsik Choi added a comment - After a patch is committed, an issue is usually closed.
        Hide
        mhthanh Mai Hai Thanh added a comment -

        OK, I have no objection.

        Show
        mhthanh Mai Hai Thanh added a comment - OK, I have no objection.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch. Thank you for your contribution.

        Here is your first commit log in Tajo project.
        https://git-wip-us.apache.org/repos/asf?p=tajo.git;a=commit;h=101413e319cd1be0e2570c6759e52d98aee89725

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch. Thank you for your contribution. Here is your first commit log in Tajo project. https://git-wip-us.apache.org/repos/asf?p=tajo.git;a=commit;h=101413e319cd1be0e2570c6759e52d98aee89725
        Hide
        blrunner Jaehwa Jung added a comment -

        Hi Mai Hai Thanh,

        Thank you for your contribution.
        Welcome to Tajo.

        Cheers

        Show
        blrunner Jaehwa Jung added a comment - Hi Mai Hai Thanh , Thank you for your contribution. Welcome to Tajo. Cheers
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #282 (See https://builds.apache.org/job/Tajo-master-build/282/)
        TAJO-912: Tsql prints wrong version. (Mai Hai Thanh via hyunsik) (hyunsik: rev 101413e319cd1be0e2570c6759e52d98aee89725)

        • tajo-common/src/main/java/org/apache/tajo/TajoConstants.java
        • tajo-client/src/main/java/org/apache/tajo/cli/HelpCommand.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #282 (See https://builds.apache.org/job/Tajo-master-build/282/ ) TAJO-912 : Tsql prints wrong version. (Mai Hai Thanh via hyunsik) (hyunsik: rev 101413e319cd1be0e2570c6759e52d98aee89725) tajo-common/src/main/java/org/apache/tajo/TajoConstants.java tajo-client/src/main/java/org/apache/tajo/cli/HelpCommand.java CHANGES

          People

          • Assignee:
            mhthanh Mai Hai Thanh
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development