Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-873

Query status is still RUNNING after session expired.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.9.0
    • Component/s: QueryMaster
    • Labels:
      None

      Description

      After a query session is expired, Query's status is RUNNING but listed finished query session in the WEB UI.
      In this case, All workers occupies their slot and waits a next task.

      1. TAJO-873_2.patch
        12 kB
        Jinho Kim
      2. TAJO-873.patch
        10 kB
        Jinho Kim

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #345 (See https://builds.apache.org/job/Tajo-master-build/345/)
        TAJO-873: Query status is still RUNNING after session expired. (Hyoungjun Kim, jinho) (jhkim: rev 839081ac8a752de899ddeb0bcd15866722ae6c27)

        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/scheduler/TestFifoScheduler.java
        • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMaster.java
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #345 (See https://builds.apache.org/job/Tajo-master-build/345/ ) TAJO-873 : Query status is still RUNNING after session expired. (Hyoungjun Kim, jinho) (jhkim: rev 839081ac8a752de899ddeb0bcd15866722ae6c27) CHANGES tajo-core/src/test/java/org/apache/tajo/scheduler/TestFifoScheduler.java tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMaster.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
        Hide
        jhkim Jinho Kim added a comment -

        Thanks, guys
        committed it.

        Show
        jhkim Jinho Kim added a comment - Thanks, guys committed it.
        Hide
        jihoonson Jihoon Son added a comment -

        No, it was just my wondering.
        I think that the latest patch is ready to commit.
        +1.
        Thanks for your work!

        Show
        jihoonson Jihoon Son added a comment - No, it was just my wondering. I think that the latest patch is ready to commit. +1. Thanks for your work!
        Hide
        jhkim Jinho Kim added a comment -

        Thanks you for your review.
        Event handler should be in same package. Do you have a problem to protected visible ?

        Show
        jhkim Jinho Kim added a comment - Thanks you for your review. Event handler should be in same package. Do you have a problem to protected visible ?
        Hide
        jihoonson Jihoon Son added a comment -

        Hi Jinho Kim, the latest patch looks good to me.
        I have just a question.
        Do you have any reasons to change the access modifier of QueryMasterTask.expireQuerySession() from public to protected?

        Show
        jihoonson Jihoon Son added a comment - Hi Jinho Kim , the latest patch looks good to me. I have just a question. Do you have any reasons to change the access modifier of QueryMasterTask.expireQuerySession() from public to protected?
        Hide
        jihoonson Jihoon Son added a comment -

        Sorry for late response.
        I'll review today.

        Show
        jihoonson Jihoon Son added a comment - Sorry for late response. I'll review today.
        Hide
        jhkim Jinho Kim added a comment -

        Jihoon Son and Hyoungjun Kim
        Could you review this?

        Show
        jhkim Jinho Kim added a comment - Jihoon Son and Hyoungjun Kim Could you review this?
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12662429/TAJO-873_2.patch
        against master revision 60858b2.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 202 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/477//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/477//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/477//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12662429/TAJO-873_2.patch against master revision 60858b2. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 202 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/477//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/477//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/477//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        I've uploaded the second patch that fix the test failure

        Show
        jhkim Jinho Kim added a comment - I've uploaded the second patch that fix the test failure
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12661420/TAJO-873.patch
        against master revision fb4135a.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 202 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in tajo-core:
        org.apache.tajo.scheduler.TestFifoScheduler

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/476//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/476//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/476//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12661420/TAJO-873.patch against master revision fb4135a. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 202 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in tajo-core: org.apache.tajo.scheduler.TestFifoScheduler Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/476//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/476//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/476//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        I’ve upload the new patch from https://github.com/apache/tajo/pull/37

        Show
        jhkim Jinho Kim added a comment - I’ve upload the new patch from https://github.com/apache/tajo/pull/37
        Hide
        hjkim Hyoungjun Kim added a comment -

        Please review this patch.
        https://github.com/apache/tajo/pull/37

        Show
        hjkim Hyoungjun Kim added a comment - Please review this patch. https://github.com/apache/tajo/pull/37

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development