Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-867

OUTER JOIN with empty result subquery produces a wrong result.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      In the following query if a subquery has no data, a Execution block for final outer join has only one task and final result is wrong.

      select * 
      from table1 a
      outer join (select * from table2 where code = '1') b
      on a.id = b.id
      

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #269 (See https://builds.apache.org/job/Tajo-master-build/269/)
        TAJO-867: OUTER JOIN with empty result subquery produces a wrong result. (missed github issue close.) (hyunsik: rev 38f1a57382d85217ffa6ce7501752146cb4e0ab5)

        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #269 (See https://builds.apache.org/job/Tajo-master-build/269/ ) TAJO-867 : OUTER JOIN with empty result subquery produces a wrong result. (missed github issue close.) (hyunsik: rev 38f1a57382d85217ffa6ce7501752146cb4e0ab5) CHANGES
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #268 (See https://builds.apache.org/job/Tajo-master-build/268/)
        TAJO-867: OUTER JOIN with empty result subquery produces a wrong result. (Hyoungjun Kim via hyunsik) (hyunsik: rev cdd358879051a19a421a9441550afbeac21c5709)

        • tajo-client/src/main/java/org/apache/tajo/cli/ExecExternalShellCommand.java
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java
        • tajo-core/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin3.sql
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-core/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin4.sql
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        • tajo-core/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin1.sql
        • tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java
        • CHANGES
        • tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-core/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin2.sql
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/JoinTupleComparator.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #268 (See https://builds.apache.org/job/Tajo-master-build/268/ ) TAJO-867 : OUTER JOIN with empty result subquery produces a wrong result. (Hyoungjun Kim via hyunsik) (hyunsik: rev cdd358879051a19a421a9441550afbeac21c5709) tajo-client/src/main/java/org/apache/tajo/cli/ExecExternalShellCommand.java tajo-core/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java tajo-core/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin3.sql tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-core/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin4.sql tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java tajo-core/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin1.sql tajo-core/src/test/java/org/apache/tajo/TajoTestingCluster.java CHANGES tajo-storage/src/main/java/org/apache/tajo/storage/RawFile.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin2.sql tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/JoinTupleComparator.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed.

        Show
        hyunsik Hyunsik Choi added a comment - committed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/35

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/35
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/35#issuecomment-47308342

        Travis CI had some problem. I just fixed it independently.

        +1
        the patch look good to me. I manually verified 'mvn clean install.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/35#issuecomment-47308342 Travis CI had some problem. I just fixed it independently. +1 the patch look good to me. I manually verified 'mvn clean install.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/35#issuecomment-46938184

        Could you rebase this patch against the latest revision?

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/35#issuecomment-46938184 Could you rebase this patch against the latest revision?
        Hide
        hjkim Hyoungjun Kim added a comment -

        Pull requested via the github. Please review this patch.

        Show
        hjkim Hyoungjun Kim added a comment - Pull requested via the github. Please review this patch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user babokim opened a pull request:

        https://github.com/apache/tajo/pull/35

        TAJO-867: OUTER JOIN with empty result subquery produces a wrong result.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/babokim/tajo TAJO-867

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/35.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #35


        commit 53797b74f5a0b31425f3bb5a18d336a057f7d5ac
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-06-05T18:27:25Z

        TAJO-868: TestDateTimeFunctions unit test is occasionally failed.

        commit 82b39e03a773f407d525116bb7c90a5ded708412
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-06-06T12:44:48Z

        TAJO-867: OUTER JOIN with empty result subquery produces a wrong result.

        commit 18d6621150b2e2bd4a24de38485a8ca3ef3e2046
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-06-06T12:45:56Z

        Merge branch 'TAJO-868' of https://github.com/hyunsik/tajo

        commit 144463b7772f1771564c9de66839fd979d3e38d4
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-06-06T14:08:48Z

        TAJO-867: OUTER JOIN with empty result subquery produces a wrong result.
        add order by clause in some test query.

        commit 990f495cbc11ed6e535e5edf879a1c72be46386e
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-06-06T14:10:56Z

        Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo

        Conflicts:
        CHANGES

        commit e2b30a8d06d261f78dd4cefbfa3a80897c3c2f76
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-06-07T02:31:41Z

        Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-867


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user babokim opened a pull request: https://github.com/apache/tajo/pull/35 TAJO-867 : OUTER JOIN with empty result subquery produces a wrong result. You can merge this pull request into a Git repository by running: $ git pull https://github.com/babokim/tajo TAJO-867 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 53797b74f5a0b31425f3bb5a18d336a057f7d5ac Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-06-05T18:27:25Z TAJO-868 : TestDateTimeFunctions unit test is occasionally failed. commit 82b39e03a773f407d525116bb7c90a5ded708412 Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-06-06T12:44:48Z TAJO-867 : OUTER JOIN with empty result subquery produces a wrong result. commit 18d6621150b2e2bd4a24de38485a8ca3ef3e2046 Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-06-06T12:45:56Z Merge branch ' TAJO-868 ' of https://github.com/hyunsik/tajo commit 144463b7772f1771564c9de66839fd979d3e38d4 Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-06-06T14:08:48Z TAJO-867 : OUTER JOIN with empty result subquery produces a wrong result. add order by clause in some test query. commit 990f495cbc11ed6e535e5edf879a1c72be46386e Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-06-06T14:10:56Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo Conflicts: CHANGES commit e2b30a8d06d261f78dd4cefbfa3a80897c3c2f76 Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-06-07T02:31:41Z Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/tajo into TAJO-867

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development