Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-844

JDBC should be support getTime, getDate, and getTimestamp.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently Tajo JDBC not support getTime, getTimestamp. And after TAJO-825 getDate() return wrong result.

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user babokim opened a pull request:

        https://github.com/apache/tajo/pull/19

        TAJO-844: JDBC should be support getTime, getDate, getTimestamp

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/babokim/tajo TAJO-844

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/19.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #19


        commit 4971c69cc7cc9c47de2210f7085872f186dc56b6
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-05-26T02:21:37Z

        TAJO-844: JDBC should be support getTime, getDate, getTimestamp

        commit 2dc62b65b98c96f6e7696554c861ff47841a073a
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-05-26T02:46:49Z

        TAJO-844: JDBC should be support getTime, getDate, getTimestamp


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user babokim opened a pull request: https://github.com/apache/tajo/pull/19 TAJO-844 : JDBC should be support getTime, getDate, getTimestamp You can merge this pull request into a Git repository by running: $ git pull https://github.com/babokim/tajo TAJO-844 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 commit 4971c69cc7cc9c47de2210f7085872f186dc56b6 Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-05-26T02:21:37Z TAJO-844 : JDBC should be support getTime, getDate, getTimestamp commit 2dc62b65b98c96f6e7696554c861ff47841a073a Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-05-26T02:46:49Z TAJO-844 : JDBC should be support getTime, getDate, getTimestamp
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/19#issuecomment-45262380

        My timezone is PDT. There is no TZ environment. In this environment, I faced some unit test failure as follows:

        Result:
        ```
        Results :

        Failed tests: testSortWithDate(org.apache.tajo.engine.query.TestSortQuery): Result Verification expected:<...(..)
        ```

        expected:
        ```
        col1,col2,col3
        -------------------------------
        1993-11-09 20:34:56.0,1997-01-28,08:34:56
        1995-11-09 20:34:56.0,1993-11-09,20:34:56
        1995-11-09 20:34:56.0,1994-02-02,17:34:56
        1997-11-09 20:34:56.0,1996-03-13,19:34:56
        1997-11-09 20:34:56.0,1996-04-12,15:34:56
        ```

        Actual:
        ```
        col1,col2,col3
        -------------------------------
        1993-11-09 20:34:56,1997-01-28,08:34:56
        1995-11-09 20:34:56,1993-11-09,20:34:56
        1995-11-09 20:34:56,1994-02-02,17:34:56
        1997-11-09 20:34:56,1996-03-13,19:34:56
        1997-11-09 20:34:56,1996-04-12,15:34:56
        ```

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/19#issuecomment-45262380 My timezone is PDT. There is no TZ environment. In this environment, I faced some unit test failure as follows: Result: ``` Results : Failed tests: testSortWithDate(org.apache.tajo.engine.query.TestSortQuery): Result Verification expected:<...(..) ``` expected: ``` col1,col2,col3 ------------------------------- 1993-11-09 20:34:56.0,1997-01-28,08:34:56 1995-11-09 20:34:56.0,1993-11-09,20:34:56 1995-11-09 20:34:56.0,1994-02-02,17:34:56 1997-11-09 20:34:56.0,1996-03-13,19:34:56 1997-11-09 20:34:56.0,1996-04-12,15:34:56 ``` Actual: ``` col1,col2,col3 ------------------------------- 1993-11-09 20:34:56,1997-01-28,08:34:56 1995-11-09 20:34:56,1993-11-09,20:34:56 1995-11-09 20:34:56,1994-02-02,17:34:56 1997-11-09 20:34:56,1996-03-13,19:34:56 1997-11-09 20:34:56,1996-04-12,15:34:56 ```
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user babokim commented on the pull request:

        https://github.com/apache/tajo/pull/19#issuecomment-45609727

        Removed ".0" from result file from test resources.

        Show
        githubbot ASF GitHub Bot added a comment - Github user babokim commented on the pull request: https://github.com/apache/tajo/pull/19#issuecomment-45609727 Removed ".0" from result file from test resources.
        Hide
        hjkim Hyoungjun Kim added a comment -

        Pull requested via the github. Please review this patch.

        Show
        hjkim Hyoungjun Kim added a comment - Pull requested via the github. Please review this patch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/19#issuecomment-45693999

        +1

        The patch looks good to me. Thank you for your contribution.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/19#issuecomment-45693999 +1 The patch looks good to me. Thank you for your contribution.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/19

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/19
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #241 (See https://builds.apache.org/job/Tajo-master-build/241/)
        TAJO-844: JDBC should be support getTime, getDate, and getTimestamp. (Hyoungjun Kim via hyunsik) (hyunsik: rev 06be06085698e575414994a26956056f326f77dd)

        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java
        • tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSetBase.java
        • CHANGES
        • tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java
        • tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #241 (See https://builds.apache.org/job/Tajo-master-build/241/ ) TAJO-844 : JDBC should be support getTime, getDate, and getTimestamp. (Hyoungjun Kim via hyunsik) (hyunsik: rev 06be06085698e575414994a26956056f326f77dd) tajo-core/src/test/java/org/apache/tajo/engine/query/TestSortQuery.java tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSetBase.java CHANGES tajo-common/src/main/java/org/apache/tajo/util/datetime/DateTimeUtil.java tajo-core/src/test/java/org/apache/tajo/jdbc/TestResultSet.java

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development