Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-843

implements COALESCE for BOOLEAN, DATE, TIME, TIMESTAMP

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      See the title. Currently Tajo's COALESCE function only supports INT, FLOAT, TEXT. We need COALESCE function for BOOLEAN, DATE, TIME, TIMESTAMP types.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #237 (See https://builds.apache.org/job/Tajo-master-build/237/)
        TAJO-843: implements COALESCE for BOOLEAN, DATE, TIME, TIMESTAMP. (Hyoungjun Kim via hyunsik) (hyunsik: rev 692ae6648be0b50b4289ca395f7d9d659033907d)

        • tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/CoalesceTimestamp.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/CoalesceTime.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/CoalesceDate.java
        • CHANGES
        • tajo-core/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java
        • tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/CoalesceBoolean.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #237 (See https://builds.apache.org/job/Tajo-master-build/237/ ) TAJO-843 : implements COALESCE for BOOLEAN, DATE, TIME, TIMESTAMP. (Hyoungjun Kim via hyunsik) (hyunsik: rev 692ae6648be0b50b4289ca395f7d9d659033907d) tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/CoalesceTimestamp.java tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/CoalesceTime.java tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/CoalesceDate.java CHANGES tajo-core/src/test/java/org/apache/tajo/engine/function/TestConditionalExpressions.java tajo-core/src/main/java/org/apache/tajo/engine/function/builtin/CoalesceBoolean.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/tajo/pull/26

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tajo/pull/26
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/26#issuecomment-45278523

        +1

        The patch looks nice to me. It includes enough unit tests.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/26#issuecomment-45278523 +1 The patch looks nice to me. It includes enough unit tests.
        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user babokim opened a pull request:

        https://github.com/apache/tajo/pull/26

        TAJO-843: implements COALESCE for BOOLEAN, DATE, TIME, TIMESTAMP

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/babokim/tajo TAJO-843

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/26.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #26


        commit 04a22c20ab76759fe72b6dea97775d94b3e2c026
        Author: 김형준 <babokim@babokim-macbook-pro.local>
        Date: 2014-05-29T06:47:50Z

        TAJO-843: implements COALESCE for BOOLEAN, DATE, TIME, TIMESTAMP


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user babokim opened a pull request: https://github.com/apache/tajo/pull/26 TAJO-843 : implements COALESCE for BOOLEAN, DATE, TIME, TIMESTAMP You can merge this pull request into a Git repository by running: $ git pull https://github.com/babokim/tajo TAJO-843 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit 04a22c20ab76759fe72b6dea97775d94b3e2c026 Author: 김형준 <babokim@babokim-macbook-pro.local> Date: 2014-05-29T06:47:50Z TAJO-843 : implements COALESCE for BOOLEAN, DATE, TIME, TIMESTAMP

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development