Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-840

Improve query result print with counting empty table.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Physical Operator, Worker
    • Labels:
      None

      Description

      If there is no data, tsql will print as follows:

      default> select * from table1;
      id,  name,  score,  type
      -------------------------------
      1,  name1-1,  1.1,  a
      2,  name1-2,  2.3,  b
      3,  name1-3,  3.4,  c
      4,  name1-4,  4.5,  d
      5,  name1-5,  5.6,  e
      
      default> select count(*) from table1 where id = 10;
      Progress: 100%, response time: 0.231 sec
      ?count
      -------------------------------
      (0 rows, 0.231 sec, 0 B selected)
      

      But it need to print result detailedly as follows:

      ?count
      -------------------------------
      0
      -------------------------------
      (1 rows, 0.231 sec, 0 B selected)
      

      Because if users implement some applications with TajoClient or TajoJDBC, they can't understand easy that a query finished successfully or a query finished unsuccessfully.

      1. TAJO-840_2.patch
        23 kB
        Jaehwa Jung
      2. TAJO-840_3.patch
        24 kB
        Jaehwa Jung
      3. TAJO-840_4.patch
        28 kB
        Jaehwa Jung
      4. TAJO-840_5.patch
        28 kB
        Jaehwa Jung
      5. TAJO-840_6.patch
        26 kB
        Jaehwa Jung
      6. TAJO-840_7.patch
        24 kB
        Jaehwa Jung
      7. TAJO-840_8.patch
        24 kB
        Jaehwa Jung
      8. TAJO-840.patch
        13 kB
        Jaehwa Jung

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #244 (See https://builds.apache.org/job/Tajo-master-build/244/)
        TAJO-840: Improve query result print with counting empty table. (jaehwa) (jhjung: rev f3092c4205054e7be75f5729588c4accb1cf97c6)

        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData2.sql
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData4.result
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData10.result
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData9.sql
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData5.result
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData6.result
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData6.sql
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData10.sql
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData9.result
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData11.sql
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbySortAggregationExec.java
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData12.sql
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData1.result
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData8.result
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData12.result
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData5.sql
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashAggregateExec.java
        • CHANGES
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData3.result
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData11.result
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData1.sql
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData3.sql
        • tajo-core/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbyHashAggregationExec.java
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData8.sql
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortAggregateExec.java
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData7.sql
        • tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData4.sql
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData2.result
        • tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData7.result
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #244 (See https://builds.apache.org/job/Tajo-master-build/244/ ) TAJO-840 : Improve query result print with counting empty table. (jaehwa) (jhjung: rev f3092c4205054e7be75f5729588c4accb1cf97c6) tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData2.sql tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData4.result tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData10.result tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData9.sql tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData5.result tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData6.result tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData6.sql tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData10.sql tajo-core/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData9.result tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData11.sql tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbySortAggregationExec.java tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData12.sql tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData1.result tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData8.result tajo-core/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData12.result tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData5.sql tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/HashAggregateExec.java CHANGES tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData3.result tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData11.result tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData1.sql tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData3.sql tajo-core/src/main/java/org/apache/tajo/worker/Task.java tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/DistinctGroupbyHashAggregationExec.java tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData8.sql tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/SortAggregateExec.java tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData7.sql tajo-core/src/test/resources/queries/TestGroupByQuery/testGroupByWithNullData4.sql tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData2.result tajo-core/src/test/resources/results/TestGroupByQuery/testGroupByWithNullData7.result
        Hide
        blrunner Jaehwa Jung added a comment -

        I've just committed it to master branch.

        Show
        blrunner Jaehwa Jung added a comment - I've just committed it to master branch.
        Hide
        blrunner Jaehwa Jung added a comment -

        This patch got +1 at RB.

        Show
        blrunner Jaehwa Jung added a comment - This patch got +1 at RB.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12649649/TAJO-840_7.patch
        against master revision 500c683.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 25 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/448//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/448//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/448//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12649649/TAJO-840_7.patch against master revision 500c683. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 25 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/448//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/448//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/448//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/21902/

        Show
        blrunner Jaehwa Jung added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/21902/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12649622/TAJO-840_6.patch
        against master revision 500c683.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 25 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/447//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/447//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/447//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12649622/TAJO-840_6.patch against master revision 500c683. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 25 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/447//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/447//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/447//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/21902/

        Show
        blrunner Jaehwa Jung added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/21902/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12648571/TAJO-840_5.patch
        against master revision 692ae66.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 25 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 188 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/444//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/444//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/444//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12648571/TAJO-840_5.patch against master revision 692ae66. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 25 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 188 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/444//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/444//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/444//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/21902/

        Show
        blrunner Jaehwa Jung added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/21902/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12647525/TAJO-840_4.patch
        against master revision 8e65022.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 25 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 188 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/442//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/442//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/442//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12647525/TAJO-840_4.patch against master revision 8e65022. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 25 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 188 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/442//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/442//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/442//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        I rebased the patch against branch master and I edited a null check condition in DistinctGroupbySortAggregationExec::next.
        https://reviews.apache.org/r/21902/

        Show
        blrunner Jaehwa Jung added a comment - I rebased the patch against branch master and I edited a null check condition in DistinctGroupbySortAggregationExec::next. https://reviews.apache.org/r/21902/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12647305/TAJO-840_3.patch
        against master revision 25c04db.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 19 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 193 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/441//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/441//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/441//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12647305/TAJO-840_3.patch against master revision 25c04db. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 19 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 193 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/441//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/441//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/441//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        I rebased the patch against branch master and I added null check condition at DistinctGroupbyHashAggregationExec.

        https://reviews.apache.org/r/21902/

        Show
        blrunner Jaehwa Jung added a comment - I rebased the patch against branch master and I added null check condition at DistinctGroupbyHashAggregationExec. https://reviews.apache.org/r/21902/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12647043/TAJO-840_2.patch
        against master revision c2477f4.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 17 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 193 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/440//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/440//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/440//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12647043/TAJO-840_2.patch against master revision c2477f4. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 193 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/440//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/440//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/440//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/21902/

        Show
        blrunner Jaehwa Jung added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/21902/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12646752/TAJO-840.patch
        against master revision 5bdfe88.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 11 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 192 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in tajo-core:
        org.apache.tajo.engine.eval.TestSQLExpression

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/431//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/431//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/431//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12646752/TAJO-840.patch against master revision 5bdfe88. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 192 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in tajo-core: org.apache.tajo.engine.eval.TestSQLExpression Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/431//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/431//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/431//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/21902/

        Show
        blrunner Jaehwa Jung added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/21902/

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development