Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-830

Some filter conditions with a SUBQUERY are removed by optimizer.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      In the case of a next query, "col3 like '1993-11-24%';" condition removed by optimized.

      select a.*
      from (
          select 
          	L_RETURNFLAG as col1, 
          	L_EXTENDEDPRICE as col2, 
          	concat(L_RECEIPTDATE, L_LINESTATUS) as col3 
          from lineitem
      ) a
      where col2 > 0 && col3 like '1993-11-24%';
      
      1. TAJO-830.patch
        51 kB
        Hyoungjun Kim

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #223 (See https://builds.apache.org/job/Tajo-master-build/223/)
        TAJO-830: Some filter conditions with a SUBQUERY are removed by optimizer. (Hyoungjun Kim via hyunsik) (hyunsik: rev e2d0464747a08dd1c0df5fd6010c878d66802ace)

        • tajo-core/src/test/resources/queries/TestUnionQuery/testUnion11.sql
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java
        • tajo-core/src/test/resources/results/TestUnionQuery/testUnion15.result
        • tajo-core/src/test/resources/queries/TestUnionQuery/testUnion14.sql
        • tajo-core/src/test/resources/queries/TestUnionQuery/testUnion16.sql
        • tajo-core/src/test/resources/queries/TestUnionQuery/testUnion13.sql
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java
        • tajo-core/src/test/resources/results/TestUnionQuery/testUnion11.result
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java
        • tajo-core/src/test/resources/queries/TestSelectQuery/testWhereCond2.sql
        • tajo-core/src/test/resources/results/TestUnionQuery/testUnion16.result
        • tajo-core/src/test/resources/results/TestUnionQuery/testUnion13.result
        • tajo-core/src/test/resources/queries/TestUnionQuery/testUnion15.sql
        • tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSet.java
        • tajo-core/src/test/resources/results/TestSelectQuery/testWhereCond2.result
        • tajo-core/src/test/resources/queries/TestUnionQuery/testUnion12.sql
        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalOptimizer.java
        • tajo-core/src/test/resources/results/TestUnionQuery/testUnion14.result
        • tajo-core/src/test/resources/results/TestUnionQuery/testUnion12.result
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/rewrite/FilterPushDownRule.java
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/GroupbyNode.java
        • tajo-core/src/test/resources/queries/TestJoinQuery/testJoinCoReferredEvalsFilterPushdown.sql
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #223 (See https://builds.apache.org/job/Tajo-master-build/223/ ) TAJO-830 : Some filter conditions with a SUBQUERY are removed by optimizer. (Hyoungjun Kim via hyunsik) (hyunsik: rev e2d0464747a08dd1c0df5fd6010c878d66802ace) tajo-core/src/test/resources/queries/TestUnionQuery/testUnion11.sql tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java tajo-core/src/test/resources/results/TestUnionQuery/testUnion15.result tajo-core/src/test/resources/queries/TestUnionQuery/testUnion14.sql tajo-core/src/test/resources/queries/TestUnionQuery/testUnion16.sql tajo-core/src/test/resources/queries/TestUnionQuery/testUnion13.sql tajo-core/src/test/java/org/apache/tajo/engine/query/TestUnionQuery.java tajo-core/src/test/resources/results/TestUnionQuery/testUnion11.result tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanPreprocessor.java tajo-core/src/test/resources/queries/TestSelectQuery/testWhereCond2.sql tajo-core/src/test/resources/results/TestUnionQuery/testUnion16.result tajo-core/src/test/resources/results/TestUnionQuery/testUnion13.result tajo-core/src/test/resources/queries/TestUnionQuery/testUnion15.sql tajo-client/src/main/java/org/apache/tajo/jdbc/TajoResultSet.java tajo-core/src/test/resources/results/TestSelectQuery/testWhereCond2.result tajo-core/src/test/resources/queries/TestUnionQuery/testUnion12.sql CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalOptimizer.java tajo-core/src/test/resources/results/TestUnionQuery/testUnion14.result tajo-core/src/test/resources/results/TestUnionQuery/testUnion12.result tajo-core/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-core/src/main/java/org/apache/tajo/engine/planner/rewrite/FilterPushDownRule.java tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/GroupbyNode.java tajo-core/src/test/resources/queries/TestJoinQuery/testJoinCoReferredEvalsFilterPushdown.sql
        Hide
        hyunsik Hyunsik Choi added a comment -

        This issue got +1 on github PR.
        https://github.com/apache/tajo/pull/12

        I've just committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - This issue got +1 on github PR. https://github.com/apache/tajo/pull/12 I've just committed it to master branch.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12645833/TAJO-830.patch
        against master revision d0528d1.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 17 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 197 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/429//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/429//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/429//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/429//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12645833/TAJO-830.patch against master revision d0528d1. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 197 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-common tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/429//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/429//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/429//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/429//console This message is automatically generated.

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development