Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: Resource Manager
    • Labels:
      None

      Description

      Currently, we don't support query scheduling.
      Hyunsik and Min Zhou started to implement the tajo scheduler on TAJO-540.
      It should be a big changes and there are many challenge.
      This issue will be a temporary solution before TAJO-540

      1. TAJO-811_20140514_12:20:40.patch
        29 kB
        Jinho Kim
      2. TAJO-811_20140515_14:47:42.patch
        30 kB
        Jinho Kim
      3. TAJO-811.patch
        30 kB
        Jinho Kim

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #219 (See https://builds.apache.org/job/Tajo-master-build/219/)
        TAJO-811: add simple fifo scheduler support. (jinho) (jinossy: rev 4a747a0f8756f046173ab2eaa15dc2b03bd78379)

        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryInProgress.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryJobManager.java
        • tajo-core/src/main/java/org/apache/tajo/scheduler/QuerySchedulingInfo.java
        • tajo-core/src/main/java/org/apache/tajo/scheduler/Scheduler.java
        • tajo-core/src/test/java/org/apache/tajo/scheduler/TestFifoScheduler.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoAdmin.java
        • tajo-core/src/main/java/org/apache/tajo/scheduler/SchedulingAlgorithms.java
        • tajo-core/src/main/java/org/apache/tajo/scheduler/SimpleFifoScheduler.java
        • CHANGES
        • tajo-core/src/main/resources/webapps/admin/query.jsp
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #219 (See https://builds.apache.org/job/Tajo-master-build/219/ ) TAJO-811 : add simple fifo scheduler support. (jinho) (jinossy: rev 4a747a0f8756f046173ab2eaa15dc2b03bd78379) tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryInProgress.java tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/src/main/java/org/apache/tajo/master/querymaster/QueryJobManager.java tajo-core/src/main/java/org/apache/tajo/scheduler/QuerySchedulingInfo.java tajo-core/src/main/java/org/apache/tajo/scheduler/Scheduler.java tajo-core/src/test/java/org/apache/tajo/scheduler/TestFifoScheduler.java tajo-client/src/main/java/org/apache/tajo/client/TajoAdmin.java tajo-core/src/main/java/org/apache/tajo/scheduler/SchedulingAlgorithms.java tajo-core/src/main/java/org/apache/tajo/scheduler/SimpleFifoScheduler.java CHANGES tajo-core/src/main/resources/webapps/admin/query.jsp
        Hide
        jhkim Jinho Kim added a comment -

        This issue got +1 from reviewboard.
        I've just committed it

        Show
        jhkim Jinho Kim added a comment - This issue got +1 from reviewboard. I've just committed it
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12644963/TAJO-811_20140515_14%3A47%3A42.patch
        against master revision 77fdbfb.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 187 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-client tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/424//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/424//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/424//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/424//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12644963/TAJO-811_20140515_14%3A47%3A42.patch against master revision 77fdbfb. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 187 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/424//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/424//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/424//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/424//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/21264/

        Show
        jhkim Jinho Kim added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/21264/
        Hide
        jhkim Jinho Kim added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/21264/

        Show
        jhkim Jinho Kim added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/21264/
        Hide
        jhkim Jinho Kim added a comment -

        Thanks, Jihoon for your comments!!

        Show
        jhkim Jinho Kim added a comment - Thanks, Jihoon for your comments!!
        Hide
        jihoonson Jihoon Son added a comment -

        Jinho Kim and I discussed offline, and the fifo scheduler is not sufficient to schedule every queries including DDLs because their execution can be postponed when Tajo is already executing a long-term query.
        So, I'll implement this feature at a different issue which implements the table-level concurrency control.

        Show
        jihoonson Jihoon Son added a comment - Jinho Kim and I discussed offline, and the fifo scheduler is not sufficient to schedule every queries including DDLs because their execution can be postponed when Tajo is already executing a long-term query. So, I'll implement this feature at a different issue which implements the table-level concurrency control.
        Hide
        jihoonson Jihoon Son added a comment -

        Hi Jinho Kim, thanks for your great contribution!

        But, I think that we need to schedule every queries submitted to Tajo including locally-executed queries and DDLs.
        The main application of this feature is the table-level concurrency control to handle concurrent operation for the same table.
        For example, drop table operations for a table should not be executed while any pre-submitted DML queries for the same table are executed.

        So, if you can do easily, do you mind including this feature to the patch?
        Otherwise, I'll do at a different issue.

        Thanks!

        Show
        jihoonson Jihoon Son added a comment - Hi Jinho Kim , thanks for your great contribution! But, I think that we need to schedule every queries submitted to Tajo including locally-executed queries and DDLs. The main application of this feature is the table-level concurrency control to handle concurrent operation for the same table. For example, drop table operations for a table should not be executed while any pre-submitted DML queries for the same table are executed. So, if you can do easily, do you mind including this feature to the patch? Otherwise, I'll do at a different issue. Thanks!
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12644104/TAJO-811.patch
        against master revision f1ead5e.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-client tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/420//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/420//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/420//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/420//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12644104/TAJO-811.patch against master revision f1ead5e. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/420//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/420//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/420//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/420//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/21264/

        Show
        jhkim Jinho Kim added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/21264/

          People

          • Assignee:
            jhkim Jinho Kim
            Reporter:
            jhkim Jinho Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development