Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-805

Multiple constant in selection emits some columns.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0, 0.8.1
    • Component/s: None
    • Labels:
      None

      Description

      The following query that has 3 constants prints out only 2 columns.

       
      default> select '##' as a1, '##' as a2, '##' as a3 from nation;
      a1,  a2
      -------------------------------
      ##,  ##
      ##,  ##
      ##,  ##
      ##,  ##
      ##,  ##
      ##,  ##
      ##,  ##
      ##,  ##
      ##,  ##
      ##,  ##
      ##,  ##
      
      1. TAJO-805.patch
        3 kB
        Hyoungjun Kim

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #207 (See https://builds.apache.org/job/Tajo-master-build/207/)
        TAJO-805: Multiple constant in selection emits some columns. (Hyoungjun Kim via hyunsik) (hyunsik: rev 064f18c2d41905604086e3f29783169d7e3d2dda)

        • CHANGES
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/NamedExprsManager.java
        • tajo-core/src/test/resources/results/TestSelectQuery/testSelectSameConstantsWithDifferentAliases2.result
        • tajo-core/src/test/resources/queries/TestSelectQuery/testSelectSameConstantsWithDifferentAliases2.sql
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #207 (See https://builds.apache.org/job/Tajo-master-build/207/ ) TAJO-805 : Multiple constant in selection emits some columns. (Hyoungjun Kim via hyunsik) (hyunsik: rev 064f18c2d41905604086e3f29783169d7e3d2dda) CHANGES tajo-core/src/main/java/org/apache/tajo/engine/planner/NamedExprsManager.java tajo-core/src/test/resources/results/TestSelectQuery/testSelectSameConstantsWithDifferentAliases2.result tajo-core/src/test/resources/queries/TestSelectQuery/testSelectSameConstantsWithDifferentAliases2.sql tajo-core/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to 0.9.0 and 0.8.1.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to 0.9.0 and 0.8.1.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch looks good to me. The patch includes the correct fix and unit test to verify the bug fix.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks good to me. The patch includes the correct fix and unit test to verify the bug fix.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12642431/TAJO-805.patch
        against master revision 6cc5006.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/398//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/398//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/398//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642431/TAJO-805.patch against master revision 6cc5006. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 189 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/398//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/398//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/398//console This message is automatically generated.
        Hide
        hjkim Hyoungjun Kim added a comment -

        Fixed that Constant Node doesn't use existing reference.
        Please review this patch.

        Show
        hjkim Hyoungjun Kim added a comment - Fixed that Constant Node doesn't use existing reference. Please review this patch.

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development