Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-799

Local query without FROM throws IllegalArgumentException in CLI

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      See title.

      default> select 'abc', '123';
      ERROR: Can not create a Path from an empty string
      java.lang.IllegalArgumentException: Can not create a Path from an empty string
      	at org.apache.hadoop.fs.Path.checkPathArg(Path.java:127)
      	at org.apache.hadoop.fs.Path.<init>(Path.java:135)
      	at org.apache.tajo.catalog.TableDesc.<init>(TableDesc.java:75)
      	at org.apache.tajo.cli.TajoCli.localQueryCompleted(TajoCli.java:381)
      	at org.apache.tajo.cli.TajoCli.executeQuery(TajoCli.java:366)
      	at org.apache.tajo.cli.TajoCli.executeParsedResults(TajoCli.java:323)
      	at org.apache.tajo.cli.TajoCli.runShell(TajoCli.java:312)
      	at org.apache.tajo.cli.TajoCli.main(TajoCli.java:484)
      
      1. TAJO-799.patch
        11 kB
        Hyoungjun Kim

        Activity

        Hide
        hjkim Hyoungjun Kim added a comment -

        I added NULL verification logic. Also fixed a bug which is not aware user defined OutputFormatter.
        Please review this patch.

        Show
        hjkim Hyoungjun Kim added a comment - I added NULL verification logic. Also fixed a bug which is not aware user defined OutputFormatter. Please review this patch.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12642226/TAJO-799.patch
        against master revision 71f394d.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-client tajo-common tajo-core.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/391//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/391//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/391//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642226/TAJO-799.patch against master revision 71f394d. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-client tajo-common tajo-core. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/391//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/391//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/391//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch looks good to me.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks good to me.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch. Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch. Thanks!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #206 (See https://builds.apache.org/job/Tajo-master-build/206/)
        TAJO-799: Local query without FROM throws IllegalArgumentException in CLI (Hyoungjun Kim via hyunsik) (hyunsik: rev 0fb823b9004a9f566bba55dd40c7defeade946d2)

        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java
        • tajo-client/src/main/java/org/apache/tajo/cli/ConnectDatabaseCommand.java
        • tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
        • tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java
        • tajo-core/src/test/resources/results/TestTajoCli/testLocalQueryWithoutFrom.result
        • CHANGES
        • tajo-client/src/main/java/org/apache/tajo/cli/DefaultTajoCliOutputFormatter.java
        • tajo-core/src/test/java/org/apache/tajo/cli/TestTajoCli.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #206 (See https://builds.apache.org/job/Tajo-master-build/206/ ) TAJO-799 : Local query without FROM throws IllegalArgumentException in CLI (Hyoungjun Kim via hyunsik) (hyunsik: rev 0fb823b9004a9f566bba55dd40c7defeade946d2) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java tajo-client/src/main/java/org/apache/tajo/cli/ConnectDatabaseCommand.java tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java tajo-core/src/test/resources/results/TestTajoCli/testLocalQueryWithoutFrom.result CHANGES tajo-client/src/main/java/org/apache/tajo/cli/DefaultTajoCliOutputFormatter.java tajo-core/src/test/java/org/apache/tajo/cli/TestTajoCli.java

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development