Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-766

Test failures in TestExecExternalShellCommand

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      In this test, the console message is checked, but it can be different according to the system's language.
      For example, the test is failed because the console message is in Korean as follows.

      this is test
      ERROR: /bin/bash: error_command: 명령어를 찾을 수 없음
      
      1. TAJO-766_2.patch
        3 kB
        Jihoon Son
      2. TAJO-766.patch
        5 kB
        Jihoon Son

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        I've changed its priority to minor. I don't think this issue is not a blocker of 0.8 because only those who do not use en_US locale will face this bug.

        Show
        hyunsik Hyunsik Choi added a comment - I've changed its priority to minor. I don't think this issue is not a blocker of 0.8 because only those who do not use en_US locale will face this bug.
        Hide
        jihoonson Jihoon Son added a comment -

        Patch submitted on RB.
        https://reviews.apache.org/r/20653/

        Show
        jihoonson Jihoon Son added a comment - Patch submitted on RB. https://reviews.apache.org/r/20653/
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks Hyunsik!
        I agree with you.

        Show
        jihoonson Jihoon Son added a comment - Thanks Hyunsik! I agree with you.
        Hide
        jihoonson Jihoon Son added a comment -

        Fixed a bug.

        Show
        jihoonson Jihoon Son added a comment - Fixed a bug.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch looks good to me and the issue looks reasonable. The existing unit tests will be failed if a user's locale is not en_US.
        I've verified 'mvn clean install'. It passed all.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks good to me and the issue looks reasonable. The existing unit tests will be failed if a user's locale is not en_US. I've verified 'mvn clean install'. It passed all.
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks Hyunsik Choi.
        I've just committed!

        Show
        jihoonson Jihoon Son added a comment - Thanks Hyunsik Choi . I've just committed!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #203 (See https://builds.apache.org/job/Tajo-master-build/203/)
        TAJO-766: Test failures in TestExecExternalShellCommand. (jihoon) (jihoonson: rev 71f394df9a45f1fe22a120918614b284c09d6347)

        • tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java
        • tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java
        • tajo-core/src/test/java/org/apache/tajo/cli/TestExecExternalShellCommand.java
        • tajo-client/src/main/java/org/apache/tajo/cli/ExecExternalShellCommand.java
        • CHANGES
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #203 (See https://builds.apache.org/job/Tajo-master-build/203/ ) TAJO-766 : Test failures in TestExecExternalShellCommand. (jihoon) (jihoonson: rev 71f394df9a45f1fe22a120918614b284c09d6347) tajo-rpc/src/test/java/org/apache/tajo/rpc/TestBlockingRpc.java tajo-client/src/main/java/org/apache/tajo/cli/TajoCli.java tajo-core/src/test/java/org/apache/tajo/cli/TestExecExternalShellCommand.java tajo-client/src/main/java/org/apache/tajo/cli/ExecExternalShellCommand.java CHANGES

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development