Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-754

failure of INSERT INTO may remove the target table.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: QueryMaster
    • Labels:
      None

      Description

      Currently, INSERT INTO is not supported yet. But, the failure of INSERT INTO may remove the target table. This is a critical bug.

      default> insert into table4 (id, name) select l_orderkey::int4, l_returnflag from tpch.lineitem;
      Internal error!
      java.io.IOException: The output directory 'hdfs://127.0.0.1:8020/tajo/warehouse/default/table4 already exists.
      	at org.apache.tajo.master.querymaster.QueryMasterTask.initStagingDir(QueryMasterTask.java:412)
      	at org.apache.tajo.master.querymaster.QueryMasterTask.init(QueryMasterTask.java:154)
      	at org.apache.tajo.master.querymaster.QueryMaster$QueryStartEventHandler.handle(QueryMaster.java:379)
      	at org.apache.tajo.master.querymaster.QueryMaster$QueryStartEventHandler.handle(QueryMaster.java:372)
      	at org.apache.tajo.master.TajoAsyncDispatcher.dispatch(TajoAsyncDispatcher.java:137)
      	at org.apache.tajo.master.TajoAsyncDispatcher$1.run(TajoAsyncDispatcher.java:79)
      	at java.lang.Thread.run(Thread.java:744)
      
      
      1. TAJO-754.patch
        2 kB
        Hyunsik Choi

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        Thank you for quick review. committed it to master and 0.8.0.

        Show
        hyunsik Hyunsik Choi added a comment - Thank you for quick review. committed it to master and 0.8.0.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639733/TAJO-754.patch
        against master revision 24805e2.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 202 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/325//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/325//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/325//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639733/TAJO-754.patch against master revision 24805e2. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 202 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/325//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/325//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/325//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        +1.

        Push it.

        Show
        blrunner Jaehwa Jung added a comment - +1. Push it.
        Hide
        hyunsik Hyunsik Choi added a comment -

        I manually tested it.

        Show
        hyunsik Hyunsik Choi added a comment - I manually tested it.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development