Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-737

Change version message when daemon starts up.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently when daemon starts up, the bellow message prints out.
      This version is not tajo version but hadoop version.

      STARTUP_MSG:   build = https://svn.apache.org/repos/asf/hadoop/common -r 1529768; compiled by 'hortonmu' on 2013-10-07T06:28Z
      
      1. TAJO-737.patch
        39 kB
        Hyunsik Choi

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        StringUtils internally uses VersionInfo which will print the property entries included in hadoop-version-info.properties. I borrow hadoop-maven-plugin which automatically generates main/resource/hadoop-version-info.properties file. Then, I changed it for Tajo. You will see the following startup message:

        STARTUP_MSG: Starting TajoMaster
        STARTUP_MSG:   host = xxx.yyy.com/192.168.0.205
        STARTUP_MSG:   args = []
        STARTUP_MSG:   version = 0.8.0-SNAPSHOT
        STARTUP_MSG:   classpath = ....
        STARTUP_MSG:   build = git@github.com:apache/tajo.git -r f1f36ec5f5ef78168dfe024c07c1ba122f2d78c6; compiled by 'hyunsik' on 2014-04-21T05:24Z
        STARTUP_MSG:   java = 1.7.0_51
        
        Show
        hyunsik Hyunsik Choi added a comment - StringUtils internally uses VersionInfo which will print the property entries included in hadoop-version-info.properties . I borrow hadoop-maven-plugin which automatically generates main/resource/hadoop-version-info.properties file. Then, I changed it for Tajo. You will see the following startup message: STARTUP_MSG: Starting TajoMaster STARTUP_MSG: host = xxx.yyy.com/192.168.0.205 STARTUP_MSG: args = [] STARTUP_MSG: version = 0.8.0-SNAPSHOT STARTUP_MSG: classpath = .... STARTUP_MSG: build = git@github.com:apache/tajo.git -r f1f36ec5f5ef78168dfe024c07c1ba122f2d78c6; compiled by 'hyunsik' on 2014-04-21T05:24Z STARTUP_MSG: java = 1.7.0_51
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12641031/TAJO-737.patch
        against master revision f1f36ec.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/364//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12641031/TAJO-737.patch against master revision f1f36ec. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac. The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/364//console This message is automatically generated.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12641031/TAJO-737.patch
        against master revision f1f36ec.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/365//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12641031/TAJO-737.patch against master revision f1f36ec. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac. The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/365//console This message is automatically generated.
        Hide
        jhkim Jinho Kim added a comment -

        +1
        Looks great for me. I've verified local cluster.
        Tajo QA is just script escape issue.

        Thanks, Hyunsik!

        Show
        jhkim Jinho Kim added a comment - +1 Looks great for me. I've verified local cluster. Tajo QA is just script escape issue. Thanks, Hyunsik!
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master and branch-0.8.0. Thanks for quick review.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master and branch-0.8.0. Thanks for quick review.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #192 (See https://builds.apache.org/job/Tajo-master-build/192/)
        TAJO-737: Change version message when daemon starts up. (hyunsik) (hyunsik: rev bbf2461a5bddc77b3597030976158e00ee88fe0d)

        • tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java
        • tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/util/Exec.java
        • tajo-common/src/main/resources/tajo-version-info.properties
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/protoc/ProtocMojo.java
        • tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/util/FileSetUtils.java
        • tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/versioninfo/VersionInfoMojo.java
        • tajo-common/pom.xml
        • CHANGES.txt
        • tajo-maven-plugins/pom.xml
        • pom.xml
        • tajo-common/src/main/java/org/apache/tajo/util/VersionInfo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #192 (See https://builds.apache.org/job/Tajo-master-build/192/ ) TAJO-737 : Change version message when daemon starts up. (hyunsik) (hyunsik: rev bbf2461a5bddc77b3597030976158e00ee88fe0d) tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/util/Exec.java tajo-common/src/main/resources/tajo-version-info.properties tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/protoc/ProtocMojo.java tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/util/FileSetUtils.java tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/versioninfo/VersionInfoMojo.java tajo-common/pom.xml CHANGES.txt tajo-maven-plugins/pom.xml pom.xml tajo-common/src/main/java/org/apache/tajo/util/VersionInfo.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #85 (See https://builds.apache.org/job/Tajo-0.8.0-build/85/)
        TAJO-737: Change version message when daemon starts up. (hyunsik) (hyunsik: rev c2ae7ed4fc6b8b6c10c5a3b11d4b7a45b27d997c)

        • CHANGES.txt
        • tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java
        • tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/protoc/ProtocMojo.java
        • tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/util/FileSetUtils.java
        • tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/util/Exec.java
        • tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java
        • tajo-common/pom.xml
        • tajo-maven-plugins/pom.xml
        • tajo-common/src/main/resources/tajo-version-info.properties
        • pom.xml
        • tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/versioninfo/VersionInfoMojo.java
        • tajo-common/src/main/java/org/apache/tajo/util/VersionInfo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #85 (See https://builds.apache.org/job/Tajo-0.8.0-build/85/ ) TAJO-737 : Change version message when daemon starts up. (hyunsik) (hyunsik: rev c2ae7ed4fc6b8b6c10c5a3b11d4b7a45b27d997c) CHANGES.txt tajo-core/src/main/java/org/apache/tajo/worker/TajoWorker.java tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/protoc/ProtocMojo.java tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/util/FileSetUtils.java tajo-core/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/util/Exec.java tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java tajo-common/pom.xml tajo-maven-plugins/pom.xml tajo-common/src/main/resources/tajo-version-info.properties pom.xml tajo-maven-plugins/src/main/java/org/apache/tajo/maven/plugin/versioninfo/VersionInfoMojo.java tajo-common/src/main/java/org/apache/tajo/util/VersionInfo.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development