Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-728

Supports expressions in 'IN predicate'

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      Tajo does not support expression IN statement.

      tpch100> select * from nation where n_nationkey in (1, 1+1, 1+2);
      ERROR: extraneous input '+' expecting {',', ')'}
      LINE 1:47 select * from nation where n_nationkey in (1, 1+1, 1+2)
      
      1. TAJO-728_2.patch
        7 kB
        Hyunsik Choi
      2. TAJO-728.patch
        7 kB
        Hyunsik Choi

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user hyunsik opened a pull request:

        https://github.com/apache/tajo/pull/3

        TAJO-728: Supports expression IN statement. (hyunsik)

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/hyunsik/tajo TAJO-728

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/tajo/pull/3.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #3


        commit 91e732011c1fdb51f6da9f1e9bfd43924f00173b
        Author: Hyunsik Choi <hyunsik@apache.org>
        Date: 2014-03-31T14:25:32Z

        TAJO-728: Supports expression IN statement. (hyunsik)


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user hyunsik opened a pull request: https://github.com/apache/tajo/pull/3 TAJO-728 : Supports expression IN statement. (hyunsik) You can merge this pull request into a Git repository by running: $ git pull https://github.com/hyunsik/tajo TAJO-728 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tajo/pull/3.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3 commit 91e732011c1fdb51f6da9f1e9bfd43924f00173b Author: Hyunsik Choi <hyunsik@apache.org> Date: 2014-03-31T14:25:32Z TAJO-728 : Supports expression IN statement. (hyunsik)
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12637835/TAJO-728.patch
        against master revision 40851e5.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 197 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/288//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/288//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/288//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12637835/TAJO-728.patch against master revision 40851e5. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 197 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/288//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/288//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/288//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        Hi Hyunsik.

        I can't apply the patch to latest source codes.
        Could you rebase the patch with the master repository?

        Cheers
        Jaehwa

        Show
        blrunner Jaehwa Jung added a comment - Hi Hyunsik. I can't apply the patch to latest source codes. Could you rebase the patch with the master repository? Cheers Jaehwa
        Hide
        hyunsik Hyunsik Choi added a comment -

        I'll submit the updated patch soon.

        Show
        hyunsik Hyunsik Choi added a comment - I'll submit the updated patch soon.
        Hide
        hyunsik Hyunsik Choi added a comment -

        I rebased the patch against the latest revision.

        Show
        hyunsik Hyunsik Choi added a comment - I rebased the patch against the latest revision.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639129/TAJO-728_2.patch
        against master revision 5b0cf0d.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 201 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/314//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/314//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/314//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639129/TAJO-728_2.patch against master revision 5b0cf0d. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 201 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/314//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/314//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/314//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        +1

        Thanks Hyunsik.
        Your patch looks good overall, and it runs successfully on my local cluster.
        Push it.

        Show
        blrunner Jaehwa Jung added a comment - +1 Thanks Hyunsik. Your patch looks good overall, and it runs successfully on my local cluster. Push it.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master and branch-0.8.0.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master and branch-0.8.0.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik commented on the pull request:

        https://github.com/apache/tajo/pull/3#issuecomment-39823254

        committed.

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik commented on the pull request: https://github.com/apache/tajo/pull/3#issuecomment-39823254 committed.
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user hyunsik closed the pull request at:

        https://github.com/apache/tajo/pull/3

        Show
        githubbot ASF GitHub Bot added a comment - Github user hyunsik closed the pull request at: https://github.com/apache/tajo/pull/3
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #161 (See https://builds.apache.org/job/Tajo-master-build/161/)
        TAJO-728: Supports expression IN statement. (hyunsik) (hyunsik: rev 8b5361a0699406b684bc755bc86957d92a08d6c0)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/EvalTreeUtil.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java
        • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #161 (See https://builds.apache.org/job/Tajo-master-build/161/ ) TAJO-728 : Supports expression IN statement. (hyunsik) (hyunsik: rev 8b5361a0699406b684bc755bc86957d92a08d6c0) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/EvalTreeUtil.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #61 (See https://builds.apache.org/job/Tajo-0.8.0-build/61/)
        TAJO-728: Supports expression IN statement. (hyunsik) (hyunsik: rev 22416a883e6eb8089867f91012a9b88b34fe05b0)

        • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/EvalTreeUtil.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #61 (See https://builds.apache.org/job/Tajo-0.8.0-build/61/ ) TAJO-728 : Supports expression IN statement. (hyunsik) (hyunsik: rev 22416a883e6eb8089867f91012a9b88b34fe05b0) tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/EvalTreeUtil.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development