Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-705

CTAS always stores tables with CSV storage type into catalog

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      I'm suspecting that this bug is introduced recently.

      The reproduction code is as follows:

      tajo> create table rctest using rcfile as select * from region_100;
      Progress: 100%, response time: 0.947 sec
      final state: QUERY_SUCCEEDED, response time: 0.947 sec
      OK
      tajo> \d rctest;
      
      table name: rctest
      table path: hdfs://gruter102:6020/tajo/warehouse/rctest
      store type: CSV
      number of rows: 5
      volume: 529 B
      Options: 
      
      schema: 
      r_regionkey	INT8
      r_name	TEXT
      r_comment	TEXT
      

      In this case, 'CSV' should be 'RCFILE'.

        Issue Links

          Activity

          Hide
          jhkim Jinho Kim added a comment -

          Created a review request against branch master in reviewboard
          https://reviews.apache.org/r/19610/

          Show
          jhkim Jinho Kim added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/19610/
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12636675/TAJO-705.patch
          against master revision 4209b83.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-core/tajo-core-backend.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/257//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/257//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/257//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-common.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/257//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636675/TAJO-705.patch against master revision 4209b83. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-common tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/257//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/257//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/257//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-common.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/257//console This message is automatically generated.
          Hide
          hyunsik Hyunsik Choi added a comment -

          +1

          Thank you for quick fix. Ship it!

          Show
          hyunsik Hyunsik Choi added a comment - +1 Thank you for quick fix. Ship it!
          Hide
          jhkim Jinho Kim added a comment -

          I've just committed it to both master branch and branch-0.8.0.

          Show
          jhkim Jinho Kim added a comment - I've just committed it to both master branch and branch-0.8.0.
          Hide
          jhkim Jinho Kim added a comment -

          Thanks hyunsik for the review!

          Show
          jhkim Jinho Kim added a comment - Thanks hyunsik for the review!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-0.8.0-build #37 (See https://builds.apache.org/job/Tajo-0.8.0-build/37/)
          TAJO-705: CTAS always stores tables with CSV storage type into catalog. (jinho) (jinossy: rev 67c2a2134afab5a281122ae99b0cdcfa72c8a1e5)

          • tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithOptions.sql
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithOptions.sql
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql
          • CHANGES.txt
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java
          • tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithStoreType.result
          • tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithOptions.result
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #37 (See https://builds.apache.org/job/Tajo-0.8.0-build/37/ ) TAJO-705 : CTAS always stores tables with CSV storage type into catalog. (jinho) (jinossy: rev 67c2a2134afab5a281122ae99b0cdcfa72c8a1e5) tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithOptions.sql tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithOptions.sql tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithStoreType.result tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithOptions.result tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Tajo-master-build #132 (See https://builds.apache.org/job/Tajo-master-build/132/)
          TAJO-705: CTAS always stores tables with CSV storage type into catalog. (jinho) (jinossy: rev 6a167aeaaea4ed1735e808875037b9796713bc1f)

          • tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithStoreType.result
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithOptions.sql
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithOptions.sql
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
          • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
          • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
          • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java
          • tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithOptions.result
          • CHANGES.txt
          • tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #132 (See https://builds.apache.org/job/Tajo-master-build/132/ ) TAJO-705 : CTAS always stores tables with CSV storage type into catalog. (jinho) (jinossy: rev 6a167aeaaea4ed1735e808875037b9796713bc1f) tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithStoreType.result tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithOptions.sql tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithOptions.sql tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/testCtasWithStoreType.sql tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java tajo-core/tajo-core-backend/src/test/resources/results/TestCTASQuery/testCtasWithOptions.result CHANGES.txt tajo-core/tajo-core-backend/src/test/resources/queries/TestCTASQuery/CtasWithStoreType.sql

            People

            • Assignee:
              jhkim Jinho Kim
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development