Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-698

Error occurs when FUNCTION and IN statement are used together.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: None
    • Labels:
      None

      Description

      See next tajo shell dump.

      tajo> select * from lineitem_100 where substr(l_shipdate, 1,4) in ('2010', '2011') limit 10;
      org.apache.tajo.algebra.FunctionExpr cannot be cast to org.apache.tajo.algebra.ColumnReferenceExpr
      
      1. TAJO-698.patch
        5 kB
        Hyunsik Choi

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        I've submitted the patch.

        Show
        hyunsik Hyunsik Choi added a comment - I've submitted the patch.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12636893/TAJO-698.patch
        against master revision e06ffa9.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 195 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/264//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/264//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/264//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636893/TAJO-698.patch against master revision e06ffa9. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 195 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/264//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/264//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/264//console This message is automatically generated.
        Hide
        sirpkt Keuntae Park added a comment -

        +1
        I love this patch and it works good!

        Actually, I had a problem with the query like followings and it also works well now

        select col1 from table1 where (case when col1 = '2014-03-21' then 1 else 0 end IN (1) )
        
        Show
        sirpkt Keuntae Park added a comment - +1 I love this patch and it works good! Actually, I had a problem with the query like followings and it also works well now select col1 from table1 where (case when col1 = '2014-03-21' then 1 else 0 end IN (1) )
        Hide
        hyunsik Hyunsik Choi added a comment -

        Thank you for quick review. I'll commit it soon.

        Show
        hyunsik Hyunsik Choi added a comment - Thank you for quick review. I'll commit it soon.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master and branch-0.8.0.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master and branch-0.8.0.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #137 (See https://builds.apache.org/job/Tajo-master-build/137/)
        TAJO-698: Error occurs when FUNCTION and IN statement are used together. (hyunsik: rev 858a8f17856c8443ffb5ee64807c84654a65650f)

        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/InEval.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #137 (See https://builds.apache.org/job/Tajo-master-build/137/ ) TAJO-698 : Error occurs when FUNCTION and IN statement are used together. (hyunsik: rev 858a8f17856c8443ffb5ee64807c84654a65650f) CHANGES.txt tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/InEval.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #43 (See https://builds.apache.org/job/Tajo-0.8.0-build/43/)
        TAJO-698: Error occurs when FUNCTION and IN statement are used together. (hyunsik: rev ecb97d400082e94e8d261dcfa36f56a184f382cb)

        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/InEval.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #43 (See https://builds.apache.org/job/Tajo-0.8.0-build/43/ ) TAJO-698 : Error occurs when FUNCTION and IN statement are used together. (hyunsik: rev ecb97d400082e94e8d261dcfa36f56a184f382cb) tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/InEval.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development