Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-692

Missing Null handling for INET4 in RowStoreUtil

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Storage
    • Labels:
      None

      Description

      See the title. Since Null values are not handled, the BufferUnderflowException occurs while data is read from ByteBuffer.

      1. TAJO-692_3.patch
        31 kB
        Jihoon Son
      2. TAJO-692_2.patch
        30 kB
        Jihoon Son
      3. TAJO-692.patch
        28 kB
        Jihoon Son

        Activity

        Hide
        jihoonson Jihoon Son added a comment -

        I attached a patch on RB.
        https://reviews.apache.org/r/19567/

        Show
        jihoonson Jihoon Son added a comment - I attached a patch on RB. https://reviews.apache.org/r/19567/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12636249/TAJO-692.patch
        against master revision 7283c58.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 193 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-core/tajo-core-pullserver tajo-storage.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/246//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/246//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/246//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-pullserver.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/246//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636249/TAJO-692.patch against master revision 7283c58. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 193 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-core/tajo-core-pullserver tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/246//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/246//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/246//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-pullserver.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/246//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        Reflect Jinho's comments.

        Show
        jihoonson Jihoon Son added a comment - Reflect Jinho's comments.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12636529/TAJO-692_2.patch
        against master revision 4209b83.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 9 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 202 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-core/tajo-core-pullserver tajo-storage.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/256//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/256//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-pullserver.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/256//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/256//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/256//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636529/TAJO-692_2.patch against master revision 4209b83. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 202 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend tajo-core/tajo-core-pullserver tajo-storage. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/256//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/256//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-pullserver.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/256//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/256//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-storage.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/256//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        Jinho gave some advises in offline.
        I reflected his advises.

        Show
        jihoonson Jihoon Son added a comment - Jinho gave some advises in offline. I reflected his advises.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12636866/TAJO-692_3.patch
        against master revision 9ecd9f6.

        -1 patch. The patch command could not apply the patch.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified test files.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/261//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636866/TAJO-692_3.patch against master revision 9ecd9f6. -1 patch. The patch command could not apply the patch. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified test files. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/261//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        Since the latest patch got +1 on RB, I committed it.

        Show
        jihoonson Jihoon Son added a comment - Since the latest patch got +1 on RB, I committed it.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #41 (See https://builds.apache.org/job/Tajo-0.8.0-build/41/)
        TAJO-692: Missing Null handling for INET4 in RowStoreUtil. (jihoon) (jihoonson: rev c08a0128e7967269830bba8a0f346fbfccd910d9)

        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2/table2.tbl
        • tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/util/TestTupleUtil.java
        • tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort2.result
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java
        • tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        • tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/RangeRetrieverHandler.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java
        • tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort2.sql
        • tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java
          TAJO-692: Missing Null handling for INET4 in RowStoreUtil. (fixed missing changes) (jihoonson: rev a6fd04e01e4c1eb10c05907282af7787bbacf812)
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #41 (See https://builds.apache.org/job/Tajo-0.8.0-build/41/ ) TAJO-692 : Missing Null handling for INET4 in RowStoreUtil. (jihoon) (jihoonson: rev c08a0128e7967269830bba8a0f346fbfccd910d9) CHANGES.txt tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2/table2.tbl tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java tajo-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/util/TestTupleUtil.java tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort2.result tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/RangeRetrieverHandler.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort2.sql tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java TAJO-692 : Missing Null handling for INET4 in RowStoreUtil. (fixed missing changes) (jihoonson: rev a6fd04e01e4c1eb10c05907282af7787bbacf812) tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #136 (See https://builds.apache.org/job/Tajo-master-build/136/)
        TAJO-692: Missing Null handling for INET4 in RowStoreUtil. (jihoon) (jihoonson: rev e06ffa93cf60ace4949ab7218077b7755c2f2425)

        • tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort2.sql
        • tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort2.result
        • tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2/table2.tbl
        • tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java
        • tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/util/TestTupleUtil.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java
        • tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/RangeRetrieverHandler.java
        • tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #136 (See https://builds.apache.org/job/Tajo-master-build/136/ ) TAJO-692 : Missing Null handling for INET4 in RowStoreUtil. (jihoon) (jihoonson: rev e06ffa93cf60ace4949ab7218077b7755c2f2425) tajo-core/tajo-core-backend/src/test/resources/queries/TestNetTypes/testSort2.sql tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testSort2.result tajo-core/tajo-core-backend/src/test/resources/dataset/TestNetTypes/table2/table2.tbl tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/PullServerAuxService.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestPhysicalPlanner.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/RangePartitionAlgorithm.java tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/pullserver/TajoPullServerService.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/planner/physical/TestBSTIndexExec.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/worker/TestRangeRetrieverHandler.java tajo-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/util/TestTupleUtil.java CHANGES.txt tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNetTypes.java tajo-storage/src/main/java/org/apache/tajo/storage/RowStoreUtil.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/RangeRetrieverHandler.java tajo-core/tajo-core-backend/src/test/resources/results/TestNetTypes/testJoin.result tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/utils/TupleUtil.java

          People

          • Assignee:
            jihoonson Jihoon Son
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development