Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-687

TajoMaster should pass tajoConf to create catalogServer

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      TajoMaster currently doesn't pass tajoConf to create catalogServer. so it create RpcConnectionPool with null tajoConf.

      so it can cause NullPointerException if you use tajo conf in NettyClientBase

      1. TAJO-687.3.patch
        2 kB
        DaeMyung Kang
      2. TAJO-687.patch
        2 kB
        DaeMyung Kang

        Activity

        Hide
        charsyam DaeMyung Kang added a comment -

        I add new constructor to pass conf

        Show
        charsyam DaeMyung Kang added a comment - I add new constructor to pass conf
        Hide
        charsyam DaeMyung Kang added a comment -
        Show
        charsyam DaeMyung Kang added a comment - I uploaded review https://reviews.apache.org/r/19221/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12634712/TAJO-687.patch
        against master revision 016b1c6.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/216//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/216//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/216//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634712/TAJO-687.patch against master revision 016b1c6. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/216//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/216//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/216//console This message is automatically generated.
        Hide
        charsyam DaeMyung Kang added a comment - - edited

        Jihoon Son
        I applied review.

        Show
        charsyam DaeMyung Kang added a comment - - edited Jihoon Son I applied review.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12635062/TAJO-687.3.patch
        against master revision f7caeb6.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/221//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/221//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/221//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12635062/TAJO-687.3.patch against master revision f7caeb6. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/221//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/221//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/221//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        Sorry for the late review.
        The latest patch looks good to me, and I'll commit it.

        Show
        jihoonson Jihoon Son added a comment - Sorry for the late review. The latest patch looks good to me, and I'll commit it.
        Hide
        jihoonson Jihoon Son added a comment -

        The latest patch god +1 on RB, and thus I just committed it.
        Thanks, DaeMyung!

        Show
        jihoonson Jihoon Son added a comment - The latest patch god +1 on RB, and thus I just committed it. Thanks, DaeMyung!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #124 (See https://builds.apache.org/job/Tajo-master-build/124/)
        TAJO-687: TajoMaster should pass tajoConf to create catalogServer. (DaeMyung Kang via jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=5f7934e6bb5aab412c676396f27e4267f55caf2c)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LocalCatalogWrapper.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #124 (See https://builds.apache.org/job/Tajo-master-build/124/ ) TAJO-687 : TajoMaster should pass tajoConf to create catalogServer. (DaeMyung Kang via jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=5f7934e6bb5aab412c676396f27e4267f55caf2c ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LocalCatalogWrapper.java CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #28 (See https://builds.apache.org/job/Tajo-0.8.0-build/28/)
        TAJO-687: TajoMaster should pass tajoConf to create catalogServer. (DaeMyung Kang via jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=85425cfc24682b600c8d59e833bd4c8735875fea)

        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LocalCatalogWrapper.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #28 (See https://builds.apache.org/job/Tajo-0.8.0-build/28/ ) TAJO-687 : TajoMaster should pass tajoConf to create catalogServer. (DaeMyung Kang via jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=85425cfc24682b600c8d59e833bd4c8735875fea ) tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/LocalCatalogWrapper.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java CHANGES.txt

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development