Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-679

TimestampDatum, TimeDatum, DateDatum should be able to be compared with NullDatum

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:

      Description

      See the title.
      Currently, InvalidOperationException occurs when the above datums are compared with NullDatum. Instead, the 'false' should be returned.

        Activity

        Hide
        alvinhenrick Alvin Henrick added a comment -

        1) compareTo returns -1 when the input date , time and timestamp is Null.
        2) equals returns false.
        3) equalsTo returns NullDatum.

        Show
        alvinhenrick Alvin Henrick added a comment - 1) compareTo returns -1 when the input date , time and timestamp is Null. 2) equals returns false. 3) equalsTo returns NullDatum.
        Hide
        jihoonson Jihoon Son added a comment -

        +1.
        This patch looks good to me.
        When the git repository is restored, I'll commit the patch.
        Thanks, Alvin!!

        Show
        jihoonson Jihoon Son added a comment - +1. This patch looks good to me. When the git repository is restored, I'll commit the patch. Thanks, Alvin!!
        Hide
        jihoonson Jihoon Son added a comment -

        I've just committed the patch.
        Alvin, many thanks for your contribution!

        Show
        jihoonson Jihoon Son added a comment - I've just committed the patch. Alvin, many thanks for your contribution!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #44 (See https://builds.apache.org/job/Tajo-0.8.0-build/44/)
        TAJO-679: TimestampDatum, TimeDatum, DateDatum should be able to be compared with NullDatum. (Alvin Henrick via jihoon) (jihoonson: rev 5d6d16571a23baf901e11f7fc7db53d3e9ce81ee)

        • tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java
        • CHANGES.txt
        • tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java
        • tajo-common/src/test/java/org/apache/tajo/datum/TestTimeDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java
        • tajo-common/src/test/java/org/apache/tajo/datum/TestDateDatum.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #44 (See https://builds.apache.org/job/Tajo-0.8.0-build/44/ ) TAJO-679 : TimestampDatum, TimeDatum, DateDatum should be able to be compared with NullDatum. (Alvin Henrick via jihoon) (jihoonson: rev 5d6d16571a23baf901e11f7fc7db53d3e9ce81ee) tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java CHANGES.txt tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java tajo-common/src/test/java/org/apache/tajo/datum/TestTimeDatum.java tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java tajo-common/src/test/java/org/apache/tajo/datum/TestDateDatum.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #139 (See https://builds.apache.org/job/Tajo-master-build/139/)
        TAJO-679: TimestampDatum, TimeDatum, DateDatum should be able to be compared with NullDatum. (Alvin Henrick via jihoon) (jihoonson: rev 6e6bac4c95293b689a1dc5a1d1798e0c1d60f58c)

        • tajo-common/src/test/java/org/apache/tajo/datum/TestTimeDatum.java
        • CHANGES.txt
        • tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java
        • tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java
        • tajo-common/src/test/java/org/apache/tajo/datum/TestDateDatum.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #139 (See https://builds.apache.org/job/Tajo-master-build/139/ ) TAJO-679 : TimestampDatum, TimeDatum, DateDatum should be able to be compared with NullDatum. (Alvin Henrick via jihoon) (jihoonson: rev 6e6bac4c95293b689a1dc5a1d1798e0c1d60f58c) tajo-common/src/test/java/org/apache/tajo/datum/TestTimeDatum.java CHANGES.txt tajo-common/src/test/java/org/apache/tajo/datum/TestTimestampDatum.java tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java tajo-common/src/test/java/org/apache/tajo/datum/TestDateDatum.java

          People

          • Assignee:
            alvinhenrick Alvin Henrick
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development