Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-663

CREATE TABLE USING RAW doesn't throw ERROR

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: SQL Parser
    • Labels:
      None

      Description

      RawFile must be used for Intermediate file. So can't use TABLE's File Format. Bellow statement expected fail but runs successfully.

      create table orders_100_raw (
      o_orderkey      INT8,
      o_month         text,
      o_custkey       INT8,
      o_orderstatus   TEXT,
      o_totalprice    FLOAT8,
      o_orderdate     TEXT,
      o_orderpriority TEXT,
      o_clerk TEXT,
      o_shippriority  INT4,
      o_comment       TEXT)
      using RAW
      
      1. TAJO-663_2.patch
        7 kB
        Jaehwa Jung
      2. TAJO-663.patch
        3 kB
        Jaehwa Jung

        Activity

        Hide
        hjkim Hyoungjun Kim added a comment -

        Using unsupported store type also must throws error.

        Show
        hjkim Hyoungjun Kim added a comment - Using unsupported store type also must throws error.
        Hide
        blrunner Jaehwa Jung added a comment -

        Hyoungjun Kim, thank you for your report.
        I'll fix it.

        Show
        blrunner Jaehwa Jung added a comment - Hyoungjun Kim , thank you for your report. I'll fix it.
        Hide
        blrunner Jaehwa Jung added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/18831/

        Show
        blrunner Jaehwa Jung added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/18831/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12633022/TAJO-663.patch
        against master revision ed4ba76.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/191//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/191//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/191//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12633022/TAJO-663.patch against master revision ed4ba76. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/191//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/191//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/191//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        I uploaded second patch, and I also updated RB.

        Show
        blrunner Jaehwa Jung added a comment - I uploaded second patch, and I also updated RB.
        Hide
        blrunner Jaehwa Jung added a comment -

        This patch got +1 at RB.
        I committed it to the master and branch-0.8.0.

        Show
        blrunner Jaehwa Jung added a comment - This patch got +1 at RB. I committed it to the master and branch-0.8.0.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-master-build #106 (See https://builds.apache.org/job/Tajo-master-build/106/)
        TAJO-663: CREATE TABLE USING RAW doesn't throw ERROR. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=9c920d894d5f6205e4ecec5d37fd7e15ecc59272)

        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-master-build #106 (See https://builds.apache.org/job/Tajo-master-build/106/ ) TAJO-663 : CREATE TABLE USING RAW doesn't throw ERROR. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=9c920d894d5f6205e4ecec5d37fd7e15ecc59272 ) tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java CHANGES.txt tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #13 (See https://builds.apache.org/job/Tajo-0.8.0-build/13/)
        TAJO-663: CREATE TABLE USING RAW doesn't throw ERROR. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=7625fb7571626e7fc3d298f4a02f0298d94c7da3)

        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
          TAJO-663: CREATE TABLE USING RAW doesn't throw ERROR. (Adding missed codes) (jhjung: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=7d10131e5b993cb179fe788f758819b64629b9f9)
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #13 (See https://builds.apache.org/job/Tajo-0.8.0-build/13/ ) TAJO-663 : CREATE TABLE USING RAW doesn't throw ERROR. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=7625fb7571626e7fc3d298f4a02f0298d94c7da3 ) tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestPredicates.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java TAJO-663 : CREATE TABLE USING RAW doesn't throw ERROR. (Adding missed codes) (jhjung: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=7d10131e5b993cb179fe788f758819b64629b9f9 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-build #107 (See https://builds.apache.org/job/Tajo-master-build/107/)
        TAJO-663: CREATE TABLE USING RAW doesn't throw ERROR. (Adding missed codes) (jhjung: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=ba6fc729e238f33cf94c22f1dca19046cf8545d4)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-build #107 (See https://builds.apache.org/job/Tajo-master-build/107/ ) TAJO-663 : CREATE TABLE USING RAW doesn't throw ERROR. (Adding missed codes) (jhjung: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=ba6fc729e238f33cf94c22f1dca19046cf8545d4 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PreLogicalPlanVerifier.java

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development