Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-652

logical planner cannot handle alias on partition columns

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      When we use alias on partition columns, the logical planner cannot recognize alias names. We should fix it.

      1. TAJO-652.patch
        16 kB
        Hyoungjun Kim

        Activity

        Hide
        hjkim Hyoungjun Kim added a comment -

        I resolved this issue. Please review this patch.
        https://reviews.apache.org/r/20517/

        Show
        hjkim Hyoungjun Kim added a comment - I resolved this issue. Please review this patch. https://reviews.apache.org/r/20517/
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        The patch looks good to me. I'll commit it shortly.

        Show
        hyunsik Hyunsik Choi added a comment - +1 The patch looks good to me. I'll commit it shortly.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #193 (See https://builds.apache.org/job/Tajo-master-build/193/)
        TAJO-652: logical planner cannot handle alias on partition columns. (Hyoungjun Kim via hyunsik) (hyunsik: rev cbe1d6e94ed7e3bdcd30d0414815736621b6b8df)

        • tajo-core/src/test/resources/queries/TestTablePartitions/case13.sql
        • tajo-core/src/test/resources/results/TestTablePartitions/case13.result
        • CHANGES.txt
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java
        • tajo-core/src/test/resources/results/TestTablePartitions/case11.result
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        • tajo-core/src/test/resources/queries/TestTablePartitions/case12.sql
        • tajo-core/src/test/resources/queries/TestTablePartitions/case11.sql
        • tajo-core/src/test/resources/results/TestTablePartitions/case12.result
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #193 (See https://builds.apache.org/job/Tajo-master-build/193/ ) TAJO-652 : logical planner cannot handle alias on partition columns. (Hyoungjun Kim via hyunsik) (hyunsik: rev cbe1d6e94ed7e3bdcd30d0414815736621b6b8df) tajo-core/src/test/resources/queries/TestTablePartitions/case13.sql tajo-core/src/test/resources/results/TestTablePartitions/case13.result CHANGES.txt tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java tajo-core/src/test/resources/results/TestTablePartitions/case11.result tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java tajo-core/src/test/resources/queries/TestTablePartitions/case12.sql tajo-core/src/test/resources/queries/TestTablePartitions/case11.sql tajo-core/src/test/resources/results/TestTablePartitions/case12.result tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12641039/TAJO-652.patch
        against master revision cbe1d6e.

        -1 patch. The patch command could not apply the patch.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 7 new or modified test files.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/366//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12641039/TAJO-652.patch against master revision cbe1d6e. -1 patch. The patch command could not apply the patch. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified test files. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/366//console This message is automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #86 (See https://builds.apache.org/job/Tajo-0.8.0-build/86/)
        TAJO-652: logical planner cannot handle alias on partition columns. (Hyoungjun Kim via hyunsik) (hyunsik: rev 6d80c7838d7bda732c6237b94b1ada1b1e0cceb2)

        • tajo-core/src/test/resources/results/TestTablePartitions/case13.result
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java
        • tajo-core/src/test/resources/queries/TestTablePartitions/case11.sql
        • tajo-core/src/test/resources/queries/TestTablePartitions/case13.sql
        • tajo-core/src/test/resources/results/TestTablePartitions/case11.result
        • tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
        • CHANGES.txt
        • tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java
        • tajo-core/src/test/resources/results/TestTablePartitions/case12.result
        • tajo-core/src/test/resources/queries/TestTablePartitions/case12.sql
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #86 (See https://builds.apache.org/job/Tajo-0.8.0-build/86/ ) TAJO-652 : logical planner cannot handle alias on partition columns. (Hyoungjun Kim via hyunsik) (hyunsik: rev 6d80c7838d7bda732c6237b94b1ada1b1e0cceb2) tajo-core/src/test/resources/results/TestTablePartitions/case13.result tajo-rpc/src/main/java/org/apache/tajo/rpc/NettyServerBase.java tajo-core/src/test/resources/queries/TestTablePartitions/case11.sql tajo-core/src/test/resources/queries/TestTablePartitions/case13.sql tajo-core/src/test/resources/results/TestTablePartitions/case11.result tajo-core/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java CHANGES.txt tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java tajo-core/src/test/resources/results/TestTablePartitions/case12.result tajo-core/src/test/resources/queries/TestTablePartitions/case12.sql
        Hide
        hyunsik Hyunsik Choi added a comment -

        It's also a major bug in 0.8. So, I committed it to both master and branch-0.8.0.

        Show
        hyunsik Hyunsik Choi added a comment - It's also a major bug in 0.8. So, I committed it to both master and branch-0.8.0.

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development