Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-628

The second stage of distinct aggregation can be scheduled to only one node.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: distributed query plan
    • Labels:
      None

      Description

      Distinct aggregation requires three stages. But, the second stage can be scheduled to one node due to wrong counting of grouping keys.

      This patch fixes this bug. In addition, this patch fixes some trivial bugs in Task.java that I found during this debugging.

      1. TAJO-628_140224_210723.patch
        9 kB
        Hyunsik Choi
      2. TAJO-628.patch
        4 kB
        Hyunsik Choi

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/18420/

        Show
        hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/18420/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12630647/TAJO-628.patch
        against master revision 9cce80c.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 178 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/157//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/157//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/157//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630647/TAJO-628.patch against master revision 9cce80c. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 178 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/157//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/157//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/157//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Added missed stop() to TajoWorkerResourceManager in unit tests.

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/18420/

        Show
        hyunsik Hyunsik Choi added a comment - Added missed stop() to TajoWorkerResourceManager in unit tests. Updated the review request against branch master in reviewboard https://reviews.apache.org/r/18420/
        Hide
        hyunsik Hyunsik Choi added a comment -

        This issue got +1 on RB. I just committed to branch-0.8.0 and master.

        Show
        hyunsik Hyunsik Choi added a comment - This issue got +1 on RB. I just committed to branch-0.8.0 and master.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #85 (See https://builds.apache.org/job/Tajo-master-build/85/)
        TAJO-628: The second stage of distinct aggregation can be scheduled to only one node. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=5eafede2fd1e9a512aedf51371291d028dbbeca3)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/master/TestTajoResourceManager.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #85 (See https://builds.apache.org/job/Tajo-master-build/85/ ) TAJO-628 : The second stage of distinct aggregation can be scheduled to only one node. (hyunsik: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=5eafede2fd1e9a512aedf51371291d028dbbeca3 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/Task.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/worker/TajoResourceAllocator.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Repartitioner.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/master/TestTajoResourceManager.java CHANGES.txt

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development