Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-614

Explaning a logical node should use ExplainLogicalPlanVisitor.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      Currently, many parts use LogicalNode::toString() for explaning plans. But, we already have ExplainLogicalPlanVisitor class to generate pretty print strings.

      This patch improves logical planning related parts to use ExplainLogicalPlanVisitor instead of toString().

      For this, I added PlannerUtil::buildExplainString for generating pretty print explain strings and simplified obsolete toString() methods of all LogicalNodes.

      It much improves the readability of explain string. I expect that it would be helpful for debugging and users' understanding of query plans.

        Attachments

        1. TAJO-614_2.patch
          75 kB
          Hyunsik Choi
        2. TAJO-614.patch
          75 kB
          Hyunsik Choi

          Activity

            People

            • Assignee:
              hyunsik Hyunsik Choi
              Reporter:
              hyunsik Hyunsik Choi
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: