Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: Catalog
    • Labels:
      None
    • Environment:

      mysql-connector-java-5.1.28.jar

      Description

      When I test MySQL catalog store instead of Derby, I get an error below. We have to fix it.

      2014-02-12 18:27:49,608 ERROR catalog.CatalogServer (CatalogServer.java:addTable(255)) - Unknown column 'TID' in 'field list'
      java.io.IOException: Unknown column 'TID' in 'field list
          at org.apache.tajo.catalog.store.AbstractDBStore.addTable(AbstractDBStore.java:326)
          at org.apache.tajo.catalog.CatalogServer$CatalogProtocolHandler.addTable(CatalogServer.java:253)
          at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:161)
          at org.apache.tajo.catalog.AbstractCatalogClient$6.call(AbstractCatalogClient.java:158)
          at org.apache.tajo.rpc.ServerCallable.withRetries(ServerCallable.java:96)
          at org.apache.tajo.catalog.AbstractCatalogClient.addTable(AbstractCatalogClient.java:158)
          at org.apache.tajo.master.GlobalEngine.createTableOnPath(GlobalEngine.java:317)
          at org.apache.tajo.master.GlobalEngine.createTable(GlobalEngine.java:280)
          at org.apache.tajo.master.GlobalEngine.updateQuery(GlobalEngine.java:221)
          at org.apache.tajo.master.GlobalEngine.executeQuery(GlobalEngine.java:142)
          at org.apache.tajo.master.TajoMasterClientService$TajoMasterClientProtocolServiceHandler.submitQuery(TajoMasterClientService.java:158)
          at org.apache.tajo.ipc.TajoMasterClientProtocol$TajoMasterClientProtocolService$2.callBlockingMethod(TajoMasterClientProtocol.java:289)
      
      1. TAJO-594.yongjun.140217.patch.txt
        12 kB
        Yongjun Park
      2. TAJO-594.yongjun.140221.patch.txt
        12 kB
        Yongjun Park
      3. TAJO-594.yongjun.140221-2.patch.txt
        10 kB
        Yongjun Park
      4. TAJO-594.yongjun.140224.patch.txt
        11 kB
        Yongjun Park
      5. TAJO-594.yongjun.140224-3.patch.txt
        11 kB
        Yongjun Park

        Issue Links

          Activity

          Hide
          hyunsik Hyunsik Choi added a comment -

          Thank you for your bug report. Its main cause is omission of TID column in the table 'TABLES'.

          The solution is to recover the following line.
          https://github.com/apache/incubator-tajo/commit/eb563addd336019417d045b95277dec9f89b8f5f#diff-94a5e2e2ee7a25af4e1574a06dfbb002L91

          Show
          hyunsik Hyunsik Choi added a comment - Thank you for your bug report. Its main cause is omission of TID column in the table 'TABLES'. The solution is to recover the following line. https://github.com/apache/incubator-tajo/commit/eb563addd336019417d045b95277dec9f89b8f5f#diff-94a5e2e2ee7a25af4e1574a06dfbb002L91
          Hide
          yongjun Yongjun Park added a comment -

          I uploaded a patch for this

          Show
          yongjun Yongjun Park added a comment - I uploaded a patch for this
          Hide
          yongjun Yongjun Park added a comment -
          Show
          yongjun Yongjun Park added a comment - Also, I created a RB; https://reviews.apache.org/r/18180/
          Hide
          tajoqa Tajo QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12629315/TAJO-594.yongjun.140217.patch.txt
          against master revision e2a7dff.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

          +1 checkstyle. The patch generated 0 code style errors.

          -1 findbugs. The patch appears to introduce 62 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server.

          Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/130//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/130//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
          Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/130//console

          This message is automatically generated.

          Show
          tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629315/TAJO-594.yongjun.140217.patch.txt against master revision e2a7dff. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 62 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-catalog/tajo-catalog-server. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/130//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/130//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/130//console This message is automatically generated.
          Hide
          blrunner Jaehwa Jung added a comment -

          Thank you for your contribution.

          You had better rebase after I push TAJO-530.

          Show
          blrunner Jaehwa Jung added a comment - Thank you for your contribution. You had better rebase after I push TAJO-530 .
          Hide
          blrunner Jaehwa Jung added a comment -

          Hi Yongjun Park.

          Thank you for your patience.
          Rebase your patch to the master branch, please.

          Show
          blrunner Jaehwa Jung added a comment - Hi Yongjun Park . Thank you for your patience. Rebase your patch to the master branch, please.
          Hide
          yongjun Yongjun Park added a comment -

          a new patch rebased on TAJO-530

          Show
          yongjun Yongjun Park added a comment - a new patch rebased on TAJO-530
          Hide
          yongjun Yongjun Park added a comment -

          Also, I updated RB: https://reviews.apache.org/r/18180/
          Jaehwa Jung, Thanks you for TAJO-530

          Show
          yongjun Yongjun Park added a comment - Also, I updated RB: https://reviews.apache.org/r/18180/ Jaehwa Jung , Thanks you for TAJO-530
          Hide
          yongjun Yongjun Park added a comment -

          Error is disappeared affected by TAJO-530.

          Show
          yongjun Yongjun Park added a comment - Error is disappeared affected by TAJO-530 .
          Hide
          yongjun Yongjun Park added a comment -

          I misunderstood TAJO-530, COLUMNS table doesn't have 'TID' field.

          Show
          yongjun Yongjun Park added a comment - I misunderstood TAJO-530 , COLUMNS table doesn't have 'TID' field.
          Hide
          yongjun Yongjun Park added a comment -

          I upload a new patch.

          Show
          yongjun Yongjun Park added a comment - I upload a new patch.
          Hide
          yongjun Yongjun Park added a comment - - edited

          add a new patch referring to https://reviews.apache.org/r/18180/diff/3/

          Show
          yongjun Yongjun Park added a comment - - edited add a new patch referring to https://reviews.apache.org/r/18180/diff/3/
          Hide
          blrunner Jaehwa Jung added a comment -

          Thank you for your contribution.

          You got +1 at RB, I just committed it to the master branch.
          Please resolve this issue.

          Show
          blrunner Jaehwa Jung added a comment - Thank you for your contribution. You got +1 at RB, I just committed it to the master branch. Please resolve this issue.
          Hide
          yongjun Yongjun Park added a comment -

          Thanks Jaehwa Jung for reviewing and comitting.

          Show
          yongjun Yongjun Park added a comment - Thanks Jaehwa Jung for reviewing and comitting.
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Tajo-master-build #80 (See https://builds.apache.org/job/Tajo-master-build/80/)
          TAJO-594: MySQL store doesn't work. (Yongjun Park via jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=ab38b5b4604cc65025164d58b76be2202059f94f)

          • CHANGES.txt
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
          • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-build #80 (See https://builds.apache.org/job/Tajo-master-build/80/ ) TAJO-594 : MySQL store doesn't work. (Yongjun Park via jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=ab38b5b4604cc65025164d58b76be2202059f94f ) CHANGES.txt tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java

            People

            • Assignee:
              yongjun Yongjun Park
              Reporter:
              yongjun Yongjun Park
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development