Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-590

Rename HiveConverter to HiveQLAnalyzer

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: SQL Parser
    • Labels:

      Description

      SQL and HiveQL are all just parser frontend. They are the same level compoenents. HiveQLAnalyzer looks more proper name than HiveQLConverter. We rename it.

      1. TAJO-590.patch
        265 kB
        Jaehwa Jung

        Activity

        Hide
        blrunner Jaehwa Jung added a comment -

        +1 for the idea.

        Show
        blrunner Jaehwa Jung added a comment - +1 for the idea.
        Hide
        sirpkt Keuntae Park added a comment -

        +1
        And, how about following renames also?
        HiveParser.g4 --> HiveQLParser.g4
        HiveLexer.g4 --> HiveQLLexer.g4

        Show
        sirpkt Keuntae Park added a comment - +1 And, how about following renames also? HiveParser.g4 --> HiveQLParser.g4 HiveLexer.g4 --> HiveQLLexer.g4
        Hide
        blrunner Jaehwa Jung added a comment - - edited

        Hyunsik Choi, could you assign this issue to me?

        I already have some issues about HiveConverter.
        So, I want to fix other issues after I fix this issue.

        P.S Keuntae Park, I agree with you.

        Show
        blrunner Jaehwa Jung added a comment - - edited Hyunsik Choi , could you assign this issue to me? I already have some issues about HiveConverter. So, I want to fix other issues after I fix this issue. P.S Keuntae Park , I agree with you.
        Hide
        hyunsik Hyunsik Choi added a comment -

        assigned. Feel free to assign 'Unasigned' issues to yourself

        Show
        hyunsik Hyunsik Choi added a comment - assigned. Feel free to assign 'Unasigned' issues to yourself
        Hide
        blrunner Jaehwa Jung added a comment -

        I uploaded the patch.

        Show
        blrunner Jaehwa Jung added a comment - I uploaded the patch.
        Hide
        blrunner Jaehwa Jung added a comment -

        I created a new RB https://reviews.apache.org/r/18349/.
        For reference, I removed unnecessary codes.
        Please review it.

        Show
        blrunner Jaehwa Jung added a comment - I created a new RB https://reviews.apache.org/r/18349/ . For reference, I removed unnecessary codes. Please review it.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12630270/TAJO-590.patch
        against master revision 5fb959b.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 178 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/153//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/153//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/153//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630270/TAJO-590.patch against master revision 5fb959b. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 178 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/153//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/153//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/153//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        I got +1 at RB.
        I committed it to the master branch.

        Show
        blrunner Jaehwa Jung added a comment - I got +1 at RB. I committed it to the master branch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #76 (See https://builds.apache.org/job/Tajo-master-build/76/)
        TAJO-590: Rename HiveConverter to HiveQLAnalyzer. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=e8da943afa1a631e8521593be1bc7a2c50bb2c63)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java
        • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveParser.g4
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java
        • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveLexer.g4
        • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLLexer.g4
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveConverter.java
        • tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLParser.g4
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveConverter.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #76 (See https://builds.apache.org/job/Tajo-master-build/76/ ) TAJO-590 : Rename HiveConverter to HiveQLAnalyzer. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=e8da943afa1a631e8521593be1bc7a2c50bb2c63 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveParser.g4 tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/GlobalEngine.java CHANGES.txt tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveLexer.g4 tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLLexer.g4 tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveConverter.java tajo-core/tajo-core-backend/src/main/antlr4/org/apache/tajo/engine/parser/HiveQLParser.g4 tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveConverter.java

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development