Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-581

Inline view on column partitioned table causes NPE

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Critical
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 0.8.0
        • Component/s: Planner/Optimizer
        • Labels:
          None

          Description

          Please take a look at an example. This query causes NPE and a wrong partitioned table rewrite result.

          select 
  * 
from (
    select 
      col1, 
      col2, 
      null_col, 
      key 
    from
      table1
    where (key = 45.0 or key = 38.0) and null_col is null
) test;
          1. Text File
            TAJO-581.patch
            57 kB
            Hyunsik Choi

            Issue Links

            is related to

            Bug - A problem which impairs or prevents the functions of the product. TAJO-580 Union query with partitioned tables cause NPE.

            • Major - Major loss of function.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. TAJO-580 Union query with partitioned tables cause NPE.

            • Major - Major loss of function.
            • Resolved

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              hyunsik Hyunsik Choi added a comment -

              Created a review request against branch master in reviewboard
              https://reviews.apache.org/r/17664/

              Show
              hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/17664/
              Hide
              Permalink
              tajoqa Tajo QA added a comment -

              -1 overall. Here are the results of testing the latest attachment
              http://issues.apache.org/jira/secure/attachment/12626703/TAJO-581.patch
              against master revision 0c0111c.

              +1 @author. The patch does not contain any @author tags.

              +1 tests included. The patch appears to include 11 new or modified test files.

              +1 javac. The applied patch does not increase the total number of javac compiler warnings.

              +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

              +1 checkstyle. The patch generated 0 code style errors.

              -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings.

              +1 release audit. The applied patch does not increase the total number of release audit warnings.

              +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

              Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/98//testReport/
              Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/98//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
              Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/98//console

              This message is automatically generated.

              Show
              tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12626703/TAJO-581.patch against master revision 0c0111c. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 11 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 191 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/98//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/98//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/98//console This message is automatically generated.
              Hide
              Permalink
              hyunsik Hyunsik Choi added a comment -

              This issue got +1 on RB. I've just committed it to master branch.

              Show
              hyunsik Hyunsik Choi added a comment - This issue got +1 on RB. I've just committed it to master branch.
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in Tajo-master-build #54 (See https://builds.apache.org/job/Tajo-master-build/54/)
              TAJO-581: Inline view on column partitioned table causes NPE. (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=0781a3864e85da47c215e4da26d7344cecb3656f)

              • tajo-core/tajo-core-backend/src/test/resources/results/TestTablePartitions/case1.result
              • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java
              • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java
              • tajo-core/tajo-core-backend/src/test/resources/results/TestTablePartitions/case2.result
              • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java
              • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/GroupbyNode.java
              • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
              • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java
              • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java
              • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/TableSubQueryNode.java
              • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java
              • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java
              • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java
              • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalOptimizer.java
              • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/PartitionedTableRewriter.java
              • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java
              • tajo-core/tajo-core-backend/src/test/resources/queries/TestTablePartitions/case2.sql
              • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/join/GreedyHeuristicJoinOrderAlgorithm.java
              • tajo-core/tajo-core-backend/src/test/resources/queries/TestTablePartitions/case1.sql
              • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
              • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
              • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java
              • CHANGES.txt
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #54 (See https://builds.apache.org/job/Tajo-master-build/54/ ) TAJO-581 : Inline view on column partitioned table causes NPE. (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=0781a3864e85da47c215e4da26d7344cecb3656f ) tajo-core/tajo-core-backend/src/test/resources/results/TestTablePartitions/case1.result tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestTablePartitions.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java tajo-core/tajo-core-backend/src/test/resources/results/TestTablePartitions/case2.result tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/TestEvalTreeUtil.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/GroupbyNode.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/TableSubQueryNode.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestSelectQuery.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalOptimizer.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/PartitionedTableRewriter.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/ProjectionPushDownRule.java tajo-core/tajo-core-backend/src/test/resources/queries/TestTablePartitions/case2.sql tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/join/GreedyHeuristicJoinOrderAlgorithm.java tajo-core/tajo-core-backend/src/test/resources/queries/TestTablePartitions/case1.sql tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java CHANGES.txt

                People

                • Assignee:
                  hyunsik Hyunsik Choi
                  Reporter:
                  hyunsik Hyunsik Choi
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development