Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:

      Description

      We should add tajo.master.client-rpc.address configuration with tajo-site.xml. Because if users use default value, users just can use '\d' command at tsql on host which TajoMaster was installed.

      1. TAJO-578.patch
        0.5 kB
        Jaehwa Jung

        Activity

        Hide
        blrunner Jaehwa Jung added a comment -

        I uploaded the patch.

        Show
        blrunner Jaehwa Jung added a comment - I uploaded the patch.
        Hide
        blrunner Jaehwa Jung added a comment -

        I updated the status.

        Show
        blrunner Jaehwa Jung added a comment - I updated the status.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12629727/TAJO-578.patch
        against master revision 3f6e071.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/143//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/143//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12629727/TAJO-578.patch against master revision 3f6e071. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/143//testReport/ Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/143//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        Show
        hyunsik Hyunsik Choi added a comment - +1
        Hide
        blrunner Jaehwa Jung added a comment -

        Thanks Hyunsik Choi.

        I committed it to the master branch.

        Show
        blrunner Jaehwa Jung added a comment - Thanks Hyunsik Choi . I committed it to the master branch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #73 (See https://builds.apache.org/job/Tajo-master-build/73/)
        TAJO-578: Update configuration for tajo-site.xml. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=e63f4b09f12fbcce493e1683e24e1788f62ef619)

        • CHANGES.txt
        • tajo-project/src/site/markdown/tajo-0.8.0-doc.md
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #73 (See https://builds.apache.org/job/Tajo-master-build/73/ ) TAJO-578 : Update configuration for tajo-site.xml. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=e63f4b09f12fbcce493e1683e24e1788f62ef619 ) CHANGES.txt tajo-project/src/site/markdown/tajo-0.8.0-doc.md

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development