Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-566

BIN/TAJO_DUMP makes wrong ddl script.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      BIN/TAJO_DUMP makes wrong ddl script.

      • duplicated partition column
      • no data type in PARTITION BY COLUMN
      • PARTITION BY COLUMN clause must be placed before LOCATION
        The following is dump result.
        CREATE EXTERNAL TABLE test1 (col1 TEXT, col2 TEXT, col3 TEXT) USING CSV WITH ('csvfile.delimiter'='|') LOCATION 'hdfs://host01/tajo/table1' PARTITION BY COLUMN(col3);
        
      1. TAJO-566.patch
        2 kB
        Hyoungjun Kim

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #44 (See https://builds.apache.org/job/Tajo-master-build/44/)
        TAJO-566: BIN/TAJO_DUMP makes wrong ddl script. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=8aa0e55d7b0bca6246d2216c45dae15a8eb81bd7)

        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/test/resources/results/testBuildDDL.result
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestDDLBuilder.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #44 (See https://builds.apache.org/job/Tajo-master-build/44/ ) TAJO-566 : BIN/TAJO_DUMP makes wrong ddl script. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=8aa0e55d7b0bca6246d2216c45dae15a8eb81bd7 ) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/DDLBuilder.java CHANGES.txt tajo-core/tajo-core-backend/src/test/resources/results/testBuildDDL.result tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestDDLBuilder.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master. thanks!

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master. thanks!
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        It's definitely a bug. Thank you for the fix.

        Show
        hyunsik Hyunsik Choi added a comment - +1 It's definitely a bug. Thank you for the fix.
        Hide
        hjkim Hyoungjun Kim added a comment -

        Created a review request against branch master in reviewboard

        Show
        hjkim Hyoungjun Kim added a comment - Created a review request against branch master in reviewboard
        Hide
        seungunchoe Seungun Choe added a comment -

        Above test results were run on older versions.
        But These problem was gone on newly uploaded version.
        New problem appeared.
        The problem is as follows.

        PARTITION BY COLUMN(o_year TEXTo_month TEXT)
        

        There is no ",".
        It's changed follows.

        PARTITION BY COLUMN(o_year TEXT, o_month TEXT)
        
        Show
        seungunchoe Seungun Choe added a comment - Above test results were run on older versions. But These problem was gone on newly uploaded version. New problem appeared. The problem is as follows. PARTITION BY COLUMN(o_year TEXTo_month TEXT) There is no ",". It's changed follows. PARTITION BY COLUMN(o_year TEXT, o_month TEXT)

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            seungunchoe Seungun Choe
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development