Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-565

FilterPushDown rewrite rule does not push filters on partitioned scans

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      See the title. After we separate table schema into physical and logical schemas, FilterPushDown does not push filter conditions on partitioned tables. This patch fixes this bug.

      1. TAJO-565.patch
        5 kB
        Hyunsik Choi

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/17454/

        Show
        hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/17454/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12625586/TAJO-565.patch
        against master revision bbf9b7b.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/90//testReport/
        Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/90//findbugsResult
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/90//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12625586/TAJO-565.patch against master revision bbf9b7b. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/90//testReport/ Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/90//findbugsResult Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/90//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        +1.
        Thanks Hyunsik Choi.
        I also had difficulty scanning partitioned tables.
        It will be helpful for me.

        Show
        blrunner Jaehwa Jung added a comment - +1. Thanks Hyunsik Choi . I also had difficulty scanning partitioned tables. It will be helpful for me.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch. Thank you for the quick review.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch. Thank you for the quick review.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #39 (See https://builds.apache.org/job/Tajo-master-build/39/)
        TAJO-565: FilterPushDown rewrite rule does not push filters on partitioned scans. (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=428accfd776f65d77e195d2448b1c14feb245359)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/FilterPushDownRule.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/PartitionedTableRewriter.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #39 (See https://builds.apache.org/job/Tajo-master-build/39/ ) TAJO-565 : FilterPushDown rewrite rule does not push filters on partitioned scans. (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=428accfd776f65d77e195d2448b1c14feb245359 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/FilterPushDownRule.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/rewrite/PartitionedTableRewriter.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development