Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-564

Show execution block's progress in querydetail.jsp

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      It is difficult to monitor the Execution Block's progress in querydetail.jsp.
      The function showing task summary data of each execution block is needed.

      ID State Started Finished Running time Progress Tasks
      eb_1390902176990_0003_000001 SUCCEEDED 2014-01-28 20:14:56 - 184.0 sec 90% 90/100
      1. querydetail.png
        162 kB
        Hyoungjun Kim
      2. TAJO-564.patch
        1.28 MB
        Hyoungjun Kim
      3. TAJO-564-2.patch
        5 kB
        Hyoungjun Kim

        Activity

        Hide
        hjkim Hyoungjun Kim added a comment -

        Added execution block's task process.
        Please review this patch.

        Show
        hjkim Hyoungjun Kim added a comment - Added execution block's task process. Please review this patch.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12625572/querydetail.png
        against master revision bbf9b7b.

        -1 patch. The patch command could not apply the patch.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/89//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12625572/querydetail.png against master revision bbf9b7b. -1 patch. The patch command could not apply the patch. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/89//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        This diff seems to include others. Could you rebase the patch?

        Show
        hyunsik Hyunsik Choi added a comment - This diff seems to include others. Could you rebase the patch?
        Hide
        hjkim Hyoungjun Kim added a comment -

        This patch rebased. Please review.

        Show
        hjkim Hyoungjun Kim added a comment - This patch rebased. Please review.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12625780/TAJO-564-2.patch
        against master revision 32775bb.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/91//testReport/
        Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/91//findbugsResult
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/91//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12625780/TAJO-564-2.patch against master revision 32775bb. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/91//testReport/ Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/91//findbugsResult Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/91//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1
        This change is very useful, and I have wanted this feature. I tested it. It works well.

        Even though Tajo QA gives -1 due to unit tests and findbugs, this is mostly jsp modification. So it doesn't need to include unit tests and findbug check.

        Show
        hyunsik Hyunsik Choi added a comment - +1 This change is very useful, and I have wanted this feature. I tested it. It works well. Even though Tajo QA gives -1 due to unit tests and findbugs, this is mostly jsp modification. So it doesn't need to include unit tests and findbug check.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #43 (See https://builds.apache.org/job/Tajo-master-build/43/)
        TAJO-564: Show execution block's progress in querydetail.jsp. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=c57804f7082c2392f5ab90367acf19cc87f48e7c)

        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querytasks.jsp
        • tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querydetail.jsp
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #43 (See https://builds.apache.org/job/Tajo-master-build/43/ ) TAJO-564 : Show execution block's progress in querydetail.jsp. (hyoungjunkim via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=c57804f7082c2392f5ab90367acf19cc87f48e7c ) CHANGES.txt tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querytasks.jsp tajo-core/tajo-core-backend/src/main/resources/webapps/worker/querydetail.jsp tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/SubQuery.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed. thank you for your contribution.

        Show
        hyunsik Hyunsik Choi added a comment - committed. thank you for your contribution.

          People

          • Assignee:
            hjkim Hyoungjun Kim
            Reporter:
            hjkim Hyoungjun Kim
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development