Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-563

INSERT OVERWRITE should not remove data before query success

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: QueryMaster, TajoMaster
    • Labels:
      None

      Description

      INSERT OVERWRITE removes a table data set regardless of query success. In addition, INSERT OVERWRITE removes a table data set upon launching a query. It is a very dangerous approach, and we have to fix it.

      1. TAJO-563.patch
        5 kB
        Hyunsik Choi

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/20198/

        Show
        hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/20198/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12639536/TAJO-563.patch
        against master revision d952b61.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 205 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-common tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/321//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/321//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/321//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/321//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12639536/TAJO-563.patch against master revision d952b61. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 205 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-common tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/321//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/321//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/321//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/321//console This message is automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #165 (See https://builds.apache.org/job/Tajo-master-build/165/)
        TAJO-563: INSERT OVERWRITE should not remove data before query success. (hyunsik) (hyunsik: rev 20cd09201af20c9084ba41805e0c70036471106f)

        • tajo-common/src/main/java/org/apache/tajo/TajoConstants.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #165 (See https://builds.apache.org/job/Tajo-master-build/165/ ) TAJO-563 : INSERT OVERWRITE should not remove data before query success. (hyunsik) (hyunsik: rev 20cd09201af20c9084ba41805e0c70036471106f) tajo-common/src/main/java/org/apache/tajo/TajoConstants.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java CHANGES.txt
        Hide
        hyunsik Hyunsik Choi added a comment -

        The latest patch got +1 on RB. committed it to master and 0.8.0 branch.

        Show
        hyunsik Hyunsik Choi added a comment - The latest patch got +1 on RB. committed it to master and 0.8.0 branch.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #65 (See https://builds.apache.org/job/Tajo-0.8.0-build/65/)
        TAJO-563: INSERT OVERWRITE should not remove data before query success. (hyunsik) (hyunsik: rev f6b086c74422ae669169e35976921b7fb2eeef13)

        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java
        • tajo-common/src/main/java/org/apache/tajo/TajoConstants.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #65 (See https://builds.apache.org/job/Tajo-0.8.0-build/65/ ) TAJO-563 : INSERT OVERWRITE should not remove data before query success. (hyunsik) (hyunsik: rev f6b086c74422ae669169e35976921b7fb2eeef13) CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/QueryMasterTask.java tajo-common/src/main/java/org/apache/tajo/TajoConstants.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/querymaster/Query.java

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development