Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-553

Add a method to the TajoClient to get finished query lists

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Java Client
    • Labels:
      None

      Description

      The current TajoClient only provides a method for retrieving lists of running queries. However, users may want to see the queries which are already finished, failed or even not started. (some queries are not started immediately after TAJO-540.)

        Activity

        Hide
        dilve Ilhyun Suh added a comment -

        Added getFinishedQueryList method in TajoClient
        Renamed getQueryList method to getRunningQueryList in TajoClient

        Show
        dilve Ilhyun Suh added a comment - Added getFinishedQueryList method in TajoClient Renamed getQueryList method to getRunningQueryList in TajoClient
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12634346/TAJO-553.patch
        against master revision 44b28e6.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/209//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634346/TAJO-553.patch against master revision 44b28e6. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. -1 javac. The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/209//console This message is automatically generated.
        Hide
        dilve Ilhyun Suh added a comment -

        Canceling this patch because it could not pass the test
        I'll upload a new patch after resolving this issue

        Show
        dilve Ilhyun Suh added a comment - Canceling this patch because it could not pass the test I'll upload a new patch after resolving this issue
        Hide
        dilve Ilhyun Suh added a comment -

        Added getFinishedQueryList method in TajoClient
        Renamed getQueryList method to getRunningQueryList in TajoClient
        Also added test method for getFinishedQueryList in TestTajoClient

        Show
        dilve Ilhyun Suh added a comment - Added getFinishedQueryList method in TajoClient Renamed getQueryList method to getRunningQueryList in TajoClient Also added test method for getFinishedQueryList in TestTajoClient
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12634428/TAJO-553.patch
        against master revision 44b28e6.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-client tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/213//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/213//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/213//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12634428/TAJO-553.patch against master revision 44b28e6. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 183 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-client tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/213//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/213//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/213//console This message is automatically generated.
        Hide
        jihoonson Jihoon Son added a comment -

        Since the latest patch got +1 on RB, I just committed it.
        Thanks for your contribution!

        Show
        jihoonson Jihoon Son added a comment - Since the latest patch got +1 on RB, I just committed it. Thanks for your contribution!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #121 (See https://builds.apache.org/job/Tajo-master-build/121/)
        TAJO-553: Add a method to the TajoClient to get finished query lists. (Ilhyun Suh via jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=016b1c658e8dbd0e190c2347ee20b38bf453674b)

        • CHANGES.txt
        • tajo-client/src/main/proto/TajoMasterClientProtocol.proto
        • tajo-client/src/main/java/org/apache/tajo/client/TajoAdmin.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestTajoClient.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #121 (See https://builds.apache.org/job/Tajo-master-build/121/ ) TAJO-553 : Add a method to the TajoClient to get finished query lists. (Ilhyun Suh via jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=016b1c658e8dbd0e190c2347ee20b38bf453674b ) CHANGES.txt tajo-client/src/main/proto/TajoMasterClientProtocol.proto tajo-client/src/main/java/org/apache/tajo/client/TajoAdmin.java tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestTajoClient.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #25 (See https://builds.apache.org/job/Tajo-0.8.0-build/25/)
        TAJO-553: Add a method to the TajoClient to get finished query lists. (Ilhyun Suh via jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=3c562ce1dc6c95cea4313db72a07a6faf363c743)

        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestTajoClient.java
        • tajo-client/src/main/proto/TajoMasterClientProtocol.proto
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java
        • tajo-client/src/main/java/org/apache/tajo/client/TajoAdmin.java
        • CHANGES.txt
        • tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #25 (See https://builds.apache.org/job/Tajo-0.8.0-build/25/ ) TAJO-553 : Add a method to the TajoClient to get finished query lists. (Ilhyun Suh via jihoon) (jihoonson: https://git-wip-us.apache.org/repos/asf/?p=incubator-tajo.git&a=commit&h=3c562ce1dc6c95cea4313db72a07a6faf363c743 ) tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestTajoClient.java tajo-client/src/main/proto/TajoMasterClientProtocol.proto tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMasterClientService.java tajo-client/src/main/java/org/apache/tajo/client/TajoAdmin.java CHANGES.txt tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java

          People

          • Assignee:
            dilve Ilhyun Suh
            Reporter:
            jihoonson Jihoon Son
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development