Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-538

Groupby queries with constant target lists doesn't work

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Planner/Optimizer
    • Labels:
      None

      Description

      select l_orderkey as gkey, '00' as num from lineitem group by lineitem.l_orderkey;
      

      Basically, target list must be either grouping key or measure. In addition, constant value can be placed on the target list with groupby.

      But, current Tajo causes error in this case. This patch fixes this bug.

      1. TAJO-538_20140121_14:20:12.patch
        7 kB
        Hyunsik Choi
      2. TAJO-538.patch
        7 kB
        Hyunsik Choi

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #23 (See https://builds.apache.org/job/Tajo-master-build/23/)
        TAJO-538: Groupby queries with constant target lists doesn't work. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=9693b739745928c67946c22f0f58254344bae88d)

        • tajo-core/tajo-core-backend/src/test/resources/results/TestGroupByQuery/testGroupBy5.result
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java
        • tajo-core/tajo-core-backend/src/test/resources/queries/TestGroupByQuery/testGroupBy5.sql
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/NamedExprsManager.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #23 (See https://builds.apache.org/job/Tajo-master-build/23/ ) TAJO-538 : Groupby queries with constant target lists doesn't work. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=9693b739745928c67946c22f0f58254344bae88d ) tajo-core/tajo-core-backend/src/test/resources/results/TestGroupByQuery/testGroupBy5.result tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestGroupByQuery.java tajo-core/tajo-core-backend/src/test/resources/queries/TestGroupByQuery/testGroupBy5.sql tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/NamedExprsManager.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12624074/TAJO-538_20140121_14%3A20%3A12.patch
        against master revision e57cf42.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 157 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/71//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/71//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/71//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12624074/TAJO-538_20140121_14%3A20%3A12.patch against master revision e57cf42. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 157 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/71//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/71//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/71//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        +1.
        'mvn clean install' finished successfully.
        Ship it.

        Show
        blrunner Jaehwa Jung added a comment - +1. 'mvn clean install' finished successfully. Ship it.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Updated the review request against branch master in reviewboard
        https://reviews.apache.org/r/17139/

        Show
        hyunsik Hyunsik Choi added a comment - Updated the review request against branch master in reviewboard https://reviews.apache.org/r/17139/
        Hide
        hyunsik Hyunsik Choi added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/17139/

        Show
        hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/17139/

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development