Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-528 Fix warnings generated by FindBugs
  3. TAJO-536

Fix warnings in tajo-core-storage

        Details

        • Type: Sub-task
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 0.8.0
        • Fix Version/s: 0.8.0
        • Component/s: Build
        • Labels:
          None

          Description

          Fix warnings in tajo-core-storage.

          1. Text File
            TAJO-536_2.patch
            79 kB
            Jinho Kim
          2. Text File
            TAJO-536.patch
            73 kB
            Jinho Kim

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jhkim Jinho Kim added a comment -

            Created a review request against branch master in reviewboard
            https://reviews.apache.org/r/17183/

            Show
            jhkim Jinho Kim added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/17183/
            Hide
            Permalink
            tajoqa Tajo QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12624332/TAJO-536.patch
            against master revision d06dd85.

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 2 new or modified test files.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

            +1 checkstyle. The patch generated 0 code style errors.

            -1 findbugs. The patch appears to introduce 201 new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in tajo-common tajo-core/tajo-core-backend tajo-core/tajo-core-pullserver tajo-core/tajo-core-storage tajo-jdbc.

            Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/73//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/73//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/73//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-storage.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/73//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/73//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-pullserver.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/73//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
            Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/73//console

            This message is automatically generated.

            Show
            tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12624332/TAJO-536.patch against master revision d06dd85. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 201 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-common tajo-core/tajo-core-backend tajo-core/tajo-core-pullserver tajo-core/tajo-core-storage tajo-jdbc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/73//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/73//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/73//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-storage.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/73//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/73//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-pullserver.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/73//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/73//console This message is automatically generated.
            Hide
            Permalink
            jhkim Jinho Kim added a comment -

            I've updated the second patch.

            Show
            jhkim Jinho Kim added a comment - I've updated the second patch.
            Hide
            Permalink
            tajoqa Tajo QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12624334/TAJO-536_2.patch
            against master revision d06dd85.

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 2 new or modified test files.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

            +1 checkstyle. The patch generated 0 code style errors.

            -1 findbugs. The patch appears to introduce 198 new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in tajo-common tajo-core/tajo-core-backend tajo-core/tajo-core-pullserver tajo-core/tajo-core-storage tajo-jdbc.

            Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/74//testReport/
            Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/74//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/74//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/74//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-pullserver.html
            Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/74//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html
            Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/74//console

            This message is automatically generated.

            Show
            tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12624334/TAJO-536_2.patch against master revision d06dd85. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 198 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-common tajo-core/tajo-core-backend tajo-core/tajo-core-pullserver tajo-core/tajo-core-storage tajo-jdbc. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/74//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/74//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-jdbc.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/74//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/74//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-pullserver.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/74//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-common.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/74//console This message is automatically generated.
            Hide
            Permalink
            jhkim Jinho Kim added a comment -

            I can't open the review request. So I've create a new review request in RB.
            https://reviews.apache.org/r/17235/

            Show
            jhkim Jinho Kim added a comment - I can't open the review request. So I've create a new review request in RB. https://reviews.apache.org/r/17235/
            Hide
            Permalink
            jhkim Jinho Kim added a comment -

            This issue got +1 from reviewboard.
            committed it to master branch.

            Show
            jhkim Jinho Kim added a comment - This issue got +1 from reviewboard. committed it to master branch.
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Tajo-master-build #33 (See https://builds.apache.org/job/Tajo-master-build/33/)
            TAJO-536: Fix warnings in tajo-core-storage. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=5ac8c77cd6d77d367e19c2bb7937e835c191199c)

            • tajo-common/src/main/java/org/apache/tajo/datum/Int8Datum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/rcfile/BytesRefArrayWritable.java
            • tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/VTuple.java
            • tajo-jdbc/src/main/java/org/apache/tajo/jdbc/MetaDataTuple.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/AbstractStorageManager.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java
            • tajo-common/src/main/java/org/apache/tajo/datum/Int4Datum.java
            • tajo-common/src/main/java/org/apache/tajo/datum/BooleanDatum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/CSVFileScanner.java
            • CHANGES.txt
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/TextSerializerDeserializer.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniScanner.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/RCFile.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/StorageManagerV2.java
            • tajo-common/src/main/java/org/apache/tajo/datum/BlobDatum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/DiskMountInfo.java
            • tajo-common/src/main/java/org/apache/tajo/datum/ProtobufDatum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/ScanScheduler.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/rcfile/BytesRefWritable.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/DiskUtil.java
            • tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/TestLazyTuple.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/RCFileScanner.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/FrameTuple.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/rcfile/NonSyncChunkedByteArrayOutputStream.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/DiskFileScanScheduler.java
            • tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java
            • tajo-common/src/main/java/org/apache/tajo/util/Bytes.java
            • tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/Tuple.java
            • tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/TestVTuple.java
            • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/SignedEval.java
            • tajo-common/src/main/java/org/apache/tajo/datum/Datum.java
            • tajo-common/src/main/java/org/apache/tajo/datum/BitDatum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/TupleComparator.java
            • tajo-common/src/main/java/org/apache/tajo/datum/Float4Datum.java
            • tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/LazyTuple.java
            • tajo-common/src/main/java/org/apache/tajo/datum/Float8Datum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/FileScanRunner.java
            • dev-support/findbugs-exclude.xml
            • tajo-common/src/main/java/org/apache/tajo/datum/NumericDatum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java
            • tajo-common/src/main/java/org/apache/tajo/datum/Inet4Datum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/ScheduledInputStream.java
            • tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/storage/Tuple.java
            • tajo-common/src/main/java/org/apache/tajo/datum/CharDatum.java
            • tajo-common/src/main/java/org/apache/tajo/datum/Int2Datum.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/RowFile.java
            • tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #33 (See https://builds.apache.org/job/Tajo-master-build/33/ ) TAJO-536 : Fix warnings in tajo-core-storage. (jinho) (jinossy: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=5ac8c77cd6d77d367e19c2bb7937e835c191199c ) tajo-common/src/main/java/org/apache/tajo/datum/Int8Datum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/rcfile/BytesRefArrayWritable.java tajo-common/src/main/java/org/apache/tajo/datum/TimeDatum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/VTuple.java tajo-jdbc/src/main/java/org/apache/tajo/jdbc/MetaDataTuple.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/AbstractStorageManager.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java tajo-common/src/main/java/org/apache/tajo/datum/Int4Datum.java tajo-common/src/main/java/org/apache/tajo/datum/BooleanDatum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/CSVFileScanner.java CHANGES.txt tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/TextSerializerDeserializer.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniScanner.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/RCFile.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/StorageManagerV2.java tajo-common/src/main/java/org/apache/tajo/datum/BlobDatum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/DiskMountInfo.java tajo-common/src/main/java/org/apache/tajo/datum/ProtobufDatum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/ScanScheduler.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/rcfile/BytesRefWritable.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/DiskUtil.java tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/TestLazyTuple.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/RCFileScanner.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/FrameTuple.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/rcfile/NonSyncChunkedByteArrayOutputStream.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/DiskFileScanScheduler.java tajo-common/src/main/java/org/apache/tajo/datum/TimestampDatum.java tajo-common/src/main/java/org/apache/tajo/util/Bytes.java tajo-common/src/main/java/org/apache/tajo/datum/DateDatum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/Tuple.java tajo-core/tajo-core-storage/src/test/java/org/apache/tajo/storage/TestVTuple.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/SignedEval.java tajo-common/src/main/java/org/apache/tajo/datum/Datum.java tajo-common/src/main/java/org/apache/tajo/datum/BitDatum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/TupleComparator.java tajo-common/src/main/java/org/apache/tajo/datum/Float4Datum.java tajo-common/src/main/java/org/apache/tajo/datum/TextDatum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/LazyTuple.java tajo-common/src/main/java/org/apache/tajo/datum/Float8Datum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/FileScanRunner.java dev-support/findbugs-exclude.xml tajo-common/src/main/java/org/apache/tajo/datum/NumericDatum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/index/bst/BSTIndex.java tajo-common/src/main/java/org/apache/tajo/datum/Inet4Datum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/v2/ScheduledInputStream.java tajo-core/tajo-core-pullserver/src/main/java/org/apache/tajo/storage/Tuple.java tajo-common/src/main/java/org/apache/tajo/datum/CharDatum.java tajo-common/src/main/java/org/apache/tajo/datum/Int2Datum.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/RowFile.java tajo-core/tajo-core-storage/src/main/java/org/apache/tajo/storage/fragment/FileFragment.java

              People

              • Assignee:
                jhkim Jinho Kim
                Reporter:
                jhkim Jinho Kim
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development