Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-471

Extract ColumnPartitonUtils class for ColumnPartition rewrite

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Physical Operator
    • Labels:
      None

      Description

      In ColumnPartitionedTableStoreExec.java and SeqScanExec.java

      They have similar rewriteColumnPartitionedTableSchema function.

      so we extract util class and should use this.

      1. TAJO-471.2.patch
        6 kB
        DaeMyung Kang
      2. TAJO-471.patch
        5 kB
        DaeMyung Kang

        Activity

        Hide
        charsyam DaeMyung Kang added a comment -

        Please review this patch. Thank you.

        Show
        charsyam DaeMyung Kang added a comment - Please review this patch. Thank you.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Here is my comment. In my opinion, ColumnPartitionUtils will have only few methods. For this purpose, we have used PlannerUtil which contains a bunch of methods about planning. I think that PlannerUtil is a nice place for rewrite method. When you move rewrite method, please rename the method name to a proper name.

        Show
        hyunsik Hyunsik Choi added a comment - Here is my comment. In my opinion, ColumnPartitionUtils will have only few methods. For this purpose, we have used PlannerUtil which contains a bunch of methods about planning. I think that PlannerUtil is a nice place for rewrite method. When you move rewrite method, please rename the method name to a proper name.
        Hide
        charsyam DaeMyung Kang added a comment -

        Hyunsik Choi Thank you for your kind review.

        I moved the rewrite function to PlannerUtil

        and rename it to rewriteColumnPartitionedTableSchema.

        Thank you.

        Show
        charsyam DaeMyung Kang added a comment - Hyunsik Choi Thank you for your kind review. I moved the rewrite function to PlannerUtil and rename it to rewriteColumnPartitionedTableSchema. Thank you.
        Hide
        hyunsik Hyunsik Choi added a comment -

        +1

        Thanks!

        Show
        hyunsik Hyunsik Choi added a comment - +1 Thanks!
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master.

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Tajo-trunk-postcommit #667 (See https://builds.apache.org/job/Tajo-trunk-postcommit/667/)
        TAJO-471: Extract ColumnPartitonUtils class for ColumnPartition rewrite. (DaeMyung Kang via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=7f98908018d6cf91f7c55ae1c5a7d300499bd1f8)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/ColumnPartitionedTableStoreExec.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Tajo-trunk-postcommit #667 (See https://builds.apache.org/job/Tajo-trunk-postcommit/667/ ) TAJO-471 : Extract ColumnPartitonUtils class for ColumnPartition rewrite. (DaeMyung Kang via hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=7f98908018d6cf91f7c55ae1c5a7d300499bd1f8 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/ColumnPartitionedTableStoreExec.java CHANGES.txt tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/PlannerUtil.java

          People

          • Assignee:
            charsyam DaeMyung Kang
            Reporter:
            charsyam DaeMyung Kang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development