Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-419

Add missing visitor methods of AlgebraVisitor and BaseAlgebraVisitor

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Labels:
      None

      Description

      This patch primarily adds all missing operator types' visitor methods of AlgebraVisitor and implements concrete methods in BaseAlgebraVisitor. Currently, BaseAlgebraVisitor may cause incorrect PlanningException because BaseAlgebraVisitor does not handle all operator types. This patch eliminates this potential bug.

      In addition, this patch contains two refactors in order to eliminate duplicate names:

      • Rename tajo.algebra.DataType to DataTypeExpr
      • Rename tajo.algebra.Target to TargetExpr
      1. TAJO-419.patch
        70 kB
        Hyunsik Choi

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-trunk-postcommit #625 (See https://builds.apache.org/job/Tajo-trunk-postcommit/625/)
        TAJO-419: Add missing visitor methods of AlgebraVisitor and BaseAlgebraVisitor. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=775cfaaad49fee4e79b7cd582b381740461fa6b9)

        • tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/DataType.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/Projection.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/CastExpr.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/Target.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/DataTypeExpr.java
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/Aggregation.java
        • tajo-algebra/src/test/java/org/apache/tajo/algebra/TestExpr.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveConverter.java
        • CHANGES.txt
        • tajo-algebra/src/main/java/org/apache/tajo/algebra/TargetExpr.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #625 (See https://builds.apache.org/job/Tajo-trunk-postcommit/625/ ) TAJO-419 : Add missing visitor methods of AlgebraVisitor and BaseAlgebraVisitor. (hyunsik) (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=775cfaaad49fee4e79b7cd582b381740461fa6b9 ) tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java tajo-algebra/src/main/java/org/apache/tajo/algebra/DataType.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java tajo-algebra/src/main/java/org/apache/tajo/algebra/Projection.java tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java tajo-algebra/src/main/java/org/apache/tajo/algebra/CastExpr.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java tajo-algebra/src/main/java/org/apache/tajo/algebra/Target.java tajo-algebra/src/main/java/org/apache/tajo/algebra/DataTypeExpr.java tajo-algebra/src/main/java/org/apache/tajo/algebra/Aggregation.java tajo-algebra/src/test/java/org/apache/tajo/algebra/TestExpr.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveConverter.java CHANGES.txt tajo-algebra/src/main/java/org/apache/tajo/algebra/TargetExpr.java
        Hide
        blrunner Jaehwa Jung added a comment -

        +1.
        'mvn clean install' finished successfully.

        Great work!
        It looks like it helps contributors implement rewrite rules.

        Show
        blrunner Jaehwa Jung added a comment - +1. 'mvn clean install' finished successfully. Great work! It looks like it helps contributors implement rewrite rules.

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development