Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-403

HiveQLAnalyzer should supports standard function in the GROUP BY Clause.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: SQL Parser
    • Labels:
      None

      Description

      If user write some function at 'group by' phase on hive query mode, it makes a exception as follows:

      tajo> set tajo.hive.query.mode=true;
      tajo> select trim(name), count(1) from table1 group by trim(name);
      Unexpected aggregation function. - signature:trim
      

      It needs to support functions at 'group by' phase on hive query mode.

      1. TAJO-403.patch
        22 kB
        Jaehwa Jung

        Activity

        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Tajo-master-build #83 (See https://builds.apache.org/job/Tajo-master-build/83/)
        TAJO-403: HiveQLAnalyzer should supports standard function in the GROUP BY Clause. (Removing unnecessary codes) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=245dbd208c1b7e5cde3e4e59313f48534f64e1b2)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Tajo-master-build #83 (See https://builds.apache.org/job/Tajo-master-build/83/ ) TAJO-403 : HiveQLAnalyzer should supports standard function in the GROUP BY Clause. (Removing unnecessary codes) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=245dbd208c1b7e5cde3e4e59313f48534f64e1b2 ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #82 (See https://builds.apache.org/job/Tajo-master-build/82/)
        TAJO-403: HiveQLAnalyzer should supports standard function in the GROUP BY Clause. (Adding missed class) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=dbe617cfc73222db3a001021d8526b186e56c49f)

        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #82 (See https://builds.apache.org/job/Tajo-master-build/82/ ) TAJO-403 : HiveQLAnalyzer should supports standard function in the GROUP BY Clause. (Adding missed class) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=dbe617cfc73222db3a001021d8526b186e56c49f ) tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #81 (See https://builds.apache.org/job/Tajo-master-build/81/)
        TAJO-403: HiveQLAnalyzer should supports standard function in the GROUP BY Clause. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=7a05b21586c7588e1b4fd26bed6b41f1ebccb499)

        • tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_3.sql
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java
        • tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_4.sql
        • tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_5.sql
        • tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_2.sql
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #81 (See https://builds.apache.org/job/Tajo-master-build/81/ ) TAJO-403 : HiveQLAnalyzer should supports standard function in the GROUP BY Clause. (jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=7a05b21586c7588e1b4fd26bed6b41f1ebccb499 ) tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_3.sql tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveQLAnalyzer.java tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_4.sql tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_5.sql tajo-core/tajo-core-backend/src/test/resources/queries/default/groupby_2.sql CHANGES.txt tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/parser/TestHiveQLAnalyzer.java
        Hide
        blrunner Jaehwa Jung added a comment -

        I got +1 at RB.
        I committed it to the master branch and 0.8.0 branch.

        Show
        blrunner Jaehwa Jung added a comment - I got +1 at RB. I committed it to the master branch and 0.8.0 branch.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12630619/TAJO-403.patch
        against master revision ab38b5b.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 178 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/156//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/156//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/156//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12630619/TAJO-403.patch against master revision ab38b5b. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 178 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/156//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/156//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/156//console This message is automatically generated.
        Hide
        blrunner Jaehwa Jung added a comment -

        I refactored TestHiveQLAnalyzer fixing this issue.
        Please review it.

        Show
        blrunner Jaehwa Jung added a comment - I refactored TestHiveQLAnalyzer fixing this issue. Please review it.
        Hide
        blrunner Jaehwa Jung added a comment -

        I uploaded the patch, and I created a new RB at https://reviews.apache.org/r/18414/.

        Show
        blrunner Jaehwa Jung added a comment - I uploaded the patch, and I created a new RB at https://reviews.apache.org/r/18414/ .

          People

          • Assignee:
            blrunner Jaehwa Jung
            Reporter:
            blrunner Jaehwa Jung
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development