Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0, 0.9.0
    • Fix Version/s: 0.8.0, 0.9.0
    • Component/s: Function/UDF
    • Labels:
      None

      Description

      This function's definition is, concat_ws(sep text, str "any" [, str "any" [, ...] ]).
      For example, concat_ws(',', 'abcde', 2, NULL, 22)'s result is abcde,2,22.
      Detailed description is "Concatenate all but first arguments with separators. The first parameter is used as a separator. NULL arguments are ignored.".

      1. TAJO-378_4.patch
        4 kB
        Seungun Choe
      2. TAJO-378_3.patch
        4 kB
        Seungun Choe
      3. TAJO-378_2.patch
        4 kB
        Seungun Choe
      4. TAJO-378_1.patch
        4 kB
        Seungun Choe
      5. TAJO-378.patch
        4 kB
        Seungun Choe

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #142 (See https://builds.apache.org/job/Tajo-master-build/142/)
        TAJO-378: Implement concat_ws function. (Seungun Choe via jaehwa) (jhjung: rev 53f7ffa54913c2d2bf6dd55f2568620d7672dd81)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/Concat_ws.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #142 (See https://builds.apache.org/job/Tajo-master-build/142/ ) TAJO-378 : Implement concat_ws function. (Seungun Choe via jaehwa) (jhjung: rev 53f7ffa54913c2d2bf6dd55f2568620d7672dd81) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/Concat_ws.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-0.8.0-build #46 (See https://builds.apache.org/job/Tajo-0.8.0-build/46/)
        TAJO-378: Implement concat_ws function. (Seungun Choe via jaehwa) (jhjung: rev a18755686b5bc2a3fafb201bb6b6292905df8f92)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/Concat_ws.java
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        • CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-0.8.0-build #46 (See https://builds.apache.org/job/Tajo-0.8.0-build/46/ ) TAJO-378 : Implement concat_ws function. (Seungun Choe via jaehwa) (jhjung: rev a18755686b5bc2a3fafb201bb6b6292905df8f92) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/Concat_ws.java tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java CHANGES.txt
        Hide
        blrunner Jaehwa Jung added a comment -

        I just committed it to the master branch and the 0.8.0 branch.

        Show
        blrunner Jaehwa Jung added a comment - I just committed it to the master branch and the 0.8.0 branch.
        Hide
        blrunner Jaehwa Jung added a comment -

        +1.

        Thank you for your contribution.
        I'll commit it at once.

        Show
        blrunner Jaehwa Jung added a comment - +1. Thank you for your contribution. I'll commit it at once.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12636280/TAJO-378_4.patch
        against master revision 7283c58.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/248//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/248//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/248//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12636280/TAJO-378_4.patch against master revision 7283c58. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/248//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/248//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/248//console This message is automatically generated.
        Hide
        seungunchoe Seungun Choe added a comment -

        Here is new patch file that is replaced StringBuffer with StringBuilder.

        Show
        seungunchoe Seungun Choe added a comment - Here is new patch file that is replaced StringBuffer with StringBuilder.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Above all, I'm very sorry for late review. This patch also has the same issue as I mentioned in TAJO-377. If you resolve the issue, I'll review it quickly.

        Show
        hyunsik Hyunsik Choi added a comment - Above all, I'm very sorry for late review. This patch also has the same issue as I mentioned in TAJO-377 . If you resolve the issue, I'll review it quickly.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632740/TAJO-378_3.patch
        against master revision e0b6f7a.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/185//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/185//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/185//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632740/TAJO-378_3.patch against master revision e0b6f7a. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/185//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/185//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/185//console This message is automatically generated.
        Hide
        seungunchoe Seungun Choe added a comment -

        I modified from String type to Stringbuffer type.
        Type means concat_ws function's return values intermediate step.

        Show
        seungunchoe Seungun Choe added a comment - I modified from String type to Stringbuffer type. Type means concat_ws function's return values intermediate step.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12632446/TAJO-378_2.patch
        against master revision f4a9fd1.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend.

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/179//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/179//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/179//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12632446/TAJO-378_2.patch against master revision f4a9fd1. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 184 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in tajo-core/tajo-core-backend. Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/179//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/179//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/179//console This message is automatically generated.
        Hide
        seungunchoe Seungun Choe added a comment -

        I'm sorry wrong attach file "TAJO-378_1.patch"

        Show
        seungunchoe Seungun Choe added a comment - I'm sorry wrong attach file " TAJO-378 _1.patch"
        Hide
        blrunner Jaehwa Jung added a comment - - edited

        I'm sorry about late review.

        First, 'mvn clean install' finished unsuccessfully. I found a error message as follows:

        Tests in error: 
          testConcat_ws(org.apache.tajo.engine.function.TestStringOperatorsAndFunctions): function concat_ws(text,text,text) does not exist
        

        Second, I recommend to use StringBuilder instead of String at Concat_ws because concat method of java.lang.String always returns new String Object. So, String objects will be targets for GC.

        Show
        blrunner Jaehwa Jung added a comment - - edited I'm sorry about late review. First, 'mvn clean install' finished unsuccessfully. I found a error message as follows: Tests in error: testConcat_ws(org.apache.tajo.engine.function.TestStringOperatorsAndFunctions): function concat_ws(text,text,text) does not exist Second, I recommend to use StringBuilder instead of String at Concat_ws because concat method of java.lang.String always returns new String Object. So, String objects will be targets for GC.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12624986/TAJO-378.patch
        against master revision eb563ad.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 192 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in tajo-core/tajo-core-backend:
        org.apache.tajo.engine.function.TestStringOperatorsAndFunctions

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/83//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/83//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/83//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12624986/TAJO-378.patch against master revision eb563ad. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 192 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in tajo-core/tajo-core-backend: org.apache.tajo.engine.function.TestStringOperatorsAndFunctions Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/83//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/83//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/83//console This message is automatically generated.
        Hide
        seungunchoe Seungun Choe added a comment -

        Please confirm my patch

        Show
        seungunchoe Seungun Choe added a comment - Please confirm my patch
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks, Seungun.

        Show
        jihoonson Jihoon Son added a comment - Thanks, Seungun.
        Hide
        jihoonson Jihoon Son added a comment -

        Thanks, Seungun.
        But, would you change the issue description with the above comment?

        Show
        jihoonson Jihoon Son added a comment - Thanks, Seungun. But, would you change the issue description with the above comment?
        Hide
        seungunchoe Seungun Choe added a comment -

        This function's definition is, concat_ws(sep text, str "any" [, str "any" [, ...] ]).
        For example, concat_ws(',', 'abcde', 2, NULL, 22)'s result is abcde,2,22.
        Detailed description is "Concatenate all but first arguments with separators. The first parameter is used as a separator. NULL arguments are ignored.".

        Show
        seungunchoe Seungun Choe added a comment - This function's definition is, concat_ws(sep text, str "any" [, str "any" [, ...] ]). For example, concat_ws(',', 'abcde', 2, NULL, 22)'s result is abcde,2,22. Detailed description is "Concatenate all but first arguments with separators. The first parameter is used as a separator. NULL arguments are ignored.".
        Hide
        jihoonson Jihoon Son added a comment -

        Please give the detailed explanation of this issue in the issue description.

        Show
        jihoonson Jihoon Son added a comment - Please give the detailed explanation of this issue in the issue description.
        Hide
        blrunner Jaehwa Jung added a comment -

        I assigned to you.

        Show
        blrunner Jaehwa Jung added a comment - I assigned to you.

          People

          • Assignee:
            seungunchoe Seungun Choe
            Reporter:
            seungunchoe Seungun Choe
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development