Uploaded image for project: 'Tajo'
  1. Tajo
  2. TAJO-372

When an exception except for network issues occurs, the operation should not be repeated.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.8.0
    • Component/s: Java Client
    • Labels:
      None

      Description

      Currently, TajoClient retries failed operations regardless of network issues. It causes unnecessary retries as follows:

      tajo> select l_shipmode, sum(case when o_orderpriority ='1-URGENT' or o_orderpriority ='2-HIGH' then 1 else 0 end) as high_line_count, sum(case when o_orderpriority <> '1-URGENT' and o_orderpriority <> '2-HIGH' then 1 else 0 end) as low_line_count from orders, lineitem where o_orderkey = l_orderkey and (l_shipmode = 'MAIL' or l_shipmode = 'SHIP') and l_commitdate < l_receiptdate and l_shipdate < l_commitdate and l_receiptdate >= '1994-01-01' and l_receiptdate < '1995-01-01' group by l_shipmode order by l_shipmode;
      Failed after attempts=3, exceptions:
      org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
      org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
      org.apache.tajo.catalog.exception.NoSuchTableException: ERROR: relation "orders" does not exist
      

      When the problem is caused by other problems except for network issues, the operations should be not retried.

      1. TAJO-372.patch
        11 kB
        Hyunsik Choi

        Activity

        Hide
        hyunsik Hyunsik Choi added a comment - - edited

        Created a review request against branch master in reviewboard

        Currently, RB has some problem. So, I just uploaded this diff to only Jira.

        Show
        hyunsik Hyunsik Choi added a comment - - edited Created a review request against branch master in reviewboard Currently, RB has some problem. So, I just uploaded this diff to only Jira.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Created a review request against branch master in reviewboard
        https://reviews.apache.org/r/17388/

        Show
        hyunsik Hyunsik Choi added a comment - Created a review request against branch master in reviewboard https://reviews.apache.org/r/17388/
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12625340/TAJO-372.patch
        against master revision eb563ad.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend tajo-rpc:
        org.apache.tajo.catalog.TestCatalogUtil
        org.apache.tajo.benchmark.TestTPCH
        org.apache.tajo.engine.query.TestCaseByCases
        org.apache.tajo.client.TestTajoClient
        org.apache.tajo.engine.query.TestNullValues
        org.apache.tajo.jdbc.TestTajoJdbc
        org.apache.tajo.engine.query.TestTablePartitions
        org.apache.tajo.engine.query.TestSortQuery
        org.apache.tajo.engine.function.TestBuiltinFunctions
        org.apache.tajo.engine.query.TestUnionQuery
        org.apache.tajo.engine.query.TestCreateTable
        org.apache.tajo.engine.query.TestSelectQuery
        org.apache.tajo.engine.query.TestJoinQuery
        org.apache.tajo.engine.query.TestCTASQuery
        org.apache.tajo.engine.query.TestInsertQuery
        org.apache.tajo.engine.query.TestGroupByQuery
        org.apache.tajo.storage.TestRowFile
        org.apache.tajo.engine.query.TestTableSubQuery

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/80//testReport/
        Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/80//findbugsResult
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/80//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12625340/TAJO-372.patch against master revision eb563ad. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend tajo-rpc: org.apache.tajo.catalog.TestCatalogUtil org.apache.tajo.benchmark.TestTPCH org.apache.tajo.engine.query.TestCaseByCases org.apache.tajo.client.TestTajoClient org.apache.tajo.engine.query.TestNullValues org.apache.tajo.jdbc.TestTajoJdbc org.apache.tajo.engine.query.TestTablePartitions org.apache.tajo.engine.query.TestSortQuery org.apache.tajo.engine.function.TestBuiltinFunctions org.apache.tajo.engine.query.TestUnionQuery org.apache.tajo.engine.query.TestCreateTable org.apache.tajo.engine.query.TestSelectQuery org.apache.tajo.engine.query.TestJoinQuery org.apache.tajo.engine.query.TestCTASQuery org.apache.tajo.engine.query.TestInsertQuery org.apache.tajo.engine.query.TestGroupByQuery org.apache.tajo.storage.TestRowFile org.apache.tajo.engine.query.TestTableSubQuery Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/80//testReport/ Findbugs results: https://builds.apache.org/job/PreCommit-TAJO-Build/80//findbugsResult Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/80//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        Now, RB works well. I uploaded it to RB too.

        Show
        hyunsik Hyunsik Choi added a comment - Now, RB works well. I uploaded it to RB too.
        Hide
        tajoqa Tajo QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12625342/TAJO-372.patch
        against master revision eb563ad.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The applied patch does not increase the total number of javadoc warnings.

        +1 checkstyle. The patch generated 0 code style errors.

        -1 findbugs. The patch appears to introduce 263 new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend tajo-rpc:
        org.apache.tajo.engine.function.TestBuiltinFunctions
        org.apache.tajo.jdbc.TestTajoJdbc
        org.apache.tajo.engine.query.TestNullValues
        org.apache.tajo.engine.query.TestUnionQuery
        org.apache.tajo.engine.query.TestGroupByQuery
        org.apache.tajo.engine.query.TestSortQuery
        org.apache.tajo.storage.TestRowFile
        org.apache.tajo.benchmark.TestTPCH
        org.apache.tajo.engine.query.TestJoinQuery
        org.apache.tajo.engine.query.TestCaseByCases
        org.apache.tajo.client.TestTajoClient
        org.apache.tajo.engine.query.TestSelectQuery
        org.apache.tajo.engine.query.TestInsertQuery
        org.apache.tajo.engine.query.TestCreateTable
        org.apache.tajo.engine.query.TestCTASQuery
        org.apache.tajo.engine.query.TestTableSubQuery
        org.apache.tajo.engine.query.TestTablePartitions

        Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/81//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-rpc.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-common.html
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html
        Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/81//console

        This message is automatically generated.

        Show
        tajoqa Tajo QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12625342/TAJO-372.patch against master revision eb563ad. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The applied patch does not increase the total number of javadoc warnings. +1 checkstyle. The patch generated 0 code style errors. -1 findbugs. The patch appears to introduce 263 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in tajo-catalog/tajo-catalog-client tajo-catalog/tajo-catalog-common tajo-catalog/tajo-catalog-server tajo-core/tajo-core-backend tajo-rpc: org.apache.tajo.engine.function.TestBuiltinFunctions org.apache.tajo.jdbc.TestTajoJdbc org.apache.tajo.engine.query.TestNullValues org.apache.tajo.engine.query.TestUnionQuery org.apache.tajo.engine.query.TestGroupByQuery org.apache.tajo.engine.query.TestSortQuery org.apache.tajo.storage.TestRowFile org.apache.tajo.benchmark.TestTPCH org.apache.tajo.engine.query.TestJoinQuery org.apache.tajo.engine.query.TestCaseByCases org.apache.tajo.client.TestTajoClient org.apache.tajo.engine.query.TestSelectQuery org.apache.tajo.engine.query.TestInsertQuery org.apache.tajo.engine.query.TestCreateTable org.apache.tajo.engine.query.TestCTASQuery org.apache.tajo.engine.query.TestTableSubQuery org.apache.tajo.engine.query.TestTablePartitions Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/81//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-rpc.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/81//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-catalog-server.html Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/81//console This message is automatically generated.
        Hide
        hyunsik Hyunsik Choi added a comment -

        committed it to master branch. Thanks for the quick review!

        Show
        hyunsik Hyunsik Choi added a comment - committed it to master branch. Thanks for the quick review!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-master-build #34 (See https://builds.apache.org/job/Tajo-master-build/34/)
        TAJO-372: When an exception except for network issues occurs, the operation should not be repeated. (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=106d29c2d9c0cb89bac3ab4efcdce1a0f2abb2fe)

        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/NoSuchFunctionException.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java
        • tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
        • tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java
        • tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestCatalogUtil.java
        • tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
        • CHANGES.txt
        • tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java
        • tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin6.sql
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-master-build #34 (See https://builds.apache.org/job/Tajo-master-build/34/ ) TAJO-372 : When an exception except for network issues occurs, the operation should not be repeated. (hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=106d29c2d9c0cb89bac3ab4efcdce1a0f2abb2fe ) tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/exception/NoSuchFunctionException.java tajo-rpc/src/main/java/org/apache/tajo/rpc/AsyncRpcServer.java tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java tajo-rpc/src/main/java/org/apache/tajo/rpc/ServerCallable.java tajo-catalog/tajo-catalog-common/src/test/java/org/apache/tajo/catalog/TestCatalogUtil.java tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java CHANGES.txt tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/ExprAnnotator.java tajo-core/tajo-core-backend/src/test/resources/queries/TestJoinQuery/testWhereClauseJoin6.sql

          People

          • Assignee:
            hyunsik Hyunsik Choi
            Reporter:
            hyunsik Hyunsik Choi
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development