Details

    • Type: New Feature
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: None
    • Labels:
      None

      Description

      I'd like to lmplement this function.
      Plz assign to me

      1. TAJO-361_6.patch
        5 kB
        Seungun Choe
      2. TAJO-361_5.patch
        5 kB
        Seungun Choe
      3. TAJO-361_4.patch
        5 kB
        Seungun Choe
      4. TAJO-361_3.patch
        5 kB
        Seungun Choe
      5. TAJO-361_2.patch
        5 kB
        Seungun Choe
      6. TAJO-361_1.patch
        5 kB
        Seungun Choe
      7. TAJO-361.patch
        5 kB
        Seungun Choe

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Tajo-trunk-postcommit #588 (See https://builds.apache.org/job/Tajo-trunk-postcommit/588/)
        TAJO-361: Implement rpad function. (Seungun Choe via jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=96665ff0b184a3c33384e40edec13003686df0cd)

        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/Rpad.java
        • CHANGES.txt
        • tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java
        • tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Tajo-trunk-postcommit #588 (See https://builds.apache.org/job/Tajo-trunk-postcommit/588/ ) TAJO-361 : Implement rpad function. (Seungun Choe via jaehwa) (jhjung: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=96665ff0b184a3c33384e40edec13003686df0cd ) tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/function/string/Rpad.java CHANGES.txt tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/function/TestStringOperatorsAndFunctions.java tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/TajoMaster.java
        Hide
        blrunner Jaehwa Jung added a comment -

        +1 for the patch.

        'mvn clean install' finished successfully.
        Thank you for your contribution.

        Show
        blrunner Jaehwa Jung added a comment - +1 for the patch. 'mvn clean install' finished successfully. Thank you for your contribution.
        Hide
        seungunchoe Seungun Choe added a comment -

        fixed some value name.

        Show
        seungunchoe Seungun Choe added a comment - fixed some value name.
        Hide
        seungunchoe Seungun Choe added a comment -

        some kinds of git using problem, so I reattached.

        Show
        seungunchoe Seungun Choe added a comment - some kinds of git using problem, so I reattached.
        Hide
        seungunchoe Seungun Choe added a comment -

        There is same issue TAJO-359.
        attached patch file.

        Show
        seungunchoe Seungun Choe added a comment - There is same issue TAJO-359 . attached patch file.
        Hide
        blrunner Jaehwa Jung added a comment - - edited

        Check my comment at TAJO-359, please.

        Show
        blrunner Jaehwa Jung added a comment - - edited Check my comment at TAJO-359 , please.
        Hide
        seungunchoe Seungun Choe added a comment -

        Keuntae Park, your comment is so usefull to me.
        rpad and lpad has more issue then my thinking.
        I was fixed your issue and repatched.

        Show
        seungunchoe Seungun Choe added a comment - Keuntae Park, your comment is so usefull to me. rpad and lpad has more issue then my thinking. I was fixed your issue and repatched.
        Hide
        sirpkt Keuntae Park added a comment -

        Actually, in rpad(string text, length int [, fill text]),
        'length' value can be smaller than the length of 'string'.
        In that case, rpad should truncate the 'string'.
        For example, rpad('hi there', 3) should return 'hi '.
        But, this patch does not account for that case.

        And, when 'fill' is not specified, space character should be used as default value.

        I think you need to consider above two points.

        Show
        sirpkt Keuntae Park added a comment - Actually, in rpad(string text, length int [, fill text] ), 'length' value can be smaller than the length of 'string'. In that case, rpad should truncate the 'string'. For example, rpad('hi there', 3) should return 'hi '. But, this patch does not account for that case. And, when 'fill' is not specified, space character should be used as default value. I think you need to consider above two points.
        Hide
        seungunchoe Seungun Choe added a comment -

        TAJO-361_1 test case function name is lpad
        So, Changed testRpad();

        Show
        seungunchoe Seungun Choe added a comment - TAJO-361 _1 test case function name is lpad So, Changed testRpad();
        Hide
        seungunchoe Seungun Choe added a comment -

        Here is different test cases path file TAJO-361_1.patch

        Show
        seungunchoe Seungun Choe added a comment - Here is different test cases path file TAJO-361 _1.patch
        Hide
        seungunchoe Seungun Choe added a comment -

        I confirmed with mvn clean install.
        There is no problem.

        Show
        seungunchoe Seungun Choe added a comment - I confirmed with mvn clean install. There is no problem.
        Hide
        jihoonson Jihoon Son added a comment -

        Seungun, I assigned to you.
        Thanks!

        Show
        jihoonson Jihoon Son added a comment - Seungun, I assigned to you. Thanks!

          People

          • Assignee:
            seungunchoe Seungun Choe
            Reporter:
            seungunchoe Seungun Choe
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development